switch to rtree from routee-compass-core crate#114
Merged
robfitzgerald merged 3 commits intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes bambam/bambam-core’s in-house PolygonalRTree implementation and migrates call sites to routee_compass_core::util::geo::PolygonalRTree, aligning with the Compass shared geo utilities and addressing issue #94.
Changes:
- Deleted the local
polygonal_rtreeutility modules frombambamandbambam-core. - Updated population and grid input plugin code to use
routee_compass_core::util::geo::PolygonalRTree(including the updated generic parameters). - Cleaned up imports where the old module was referenced.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/bambam/src/util/polygonal_rtree.rs | Removed local PolygonalRTree implementation (now relying on routee-compass-core). |
| rust/bambam/src/util/mod.rs | Dropped polygonal_rtree module export. |
| rust/bambam/src/model/input_plugin/population/us_states_lookup.rs | Switched state lookup R-tree type/import to routee-compass-core. |
| rust/bambam/src/model/input_plugin/population/population_source.rs | Updated stored R-tree type to the new generic signature and import source. |
| rust/bambam/src/model/input_plugin/grid/grid_input_plugin.rs | Updated imports and function signature to use routee-compass-core PolygonalRTree. |
| rust/bambam/src/app/oppvec/app.rs | Removed now-unused PolygonalRTree import. |
| rust/bambam-core/src/util/polygonal_rtree.rs | Removed duplicate local PolygonalRTree implementation from bambam-core. |
| rust/bambam-core/src/util/mod.rs | Dropped polygonal_rtree module export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rust/bambam/src/model/input_plugin/population/population_source.rs
Outdated
Show resolved
Hide resolved
rust/bambam/src/model/input_plugin/population/population_source.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR Closes #94 by removing the PolygonalRTree type(s) from bambam and replacing with calls to the routee-compass-core rtree.