Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GBFS traversal model into a geofencing constraint model. The changes rename Gbfs references to Geofence, introduce a new frontier constraint model for geofence validation, and add a geofence testing engine with unit tests. Additionally, architectural diagrams documenting the GBFS onboarding discussion are included.
Key changes:
- Renamed GBFS traversal components to Geofence to reflect the geofencing-focused implementation
- Added a new
GeofenceConstraintModelfrontier model with a stubbed geofence testing engine - Added unit test for the
in_geofencemethod demonstrating point-in-polygon validation
Reviewed changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust/bambam/src/model/builders.rs | Registers the new GeofenceConstraintBuilder and GeofenceTraversalBuilder with the Compass builder inventory |
| rust/bambam/Cargo.toml | Adds dependency on bambam-gbfs crate |
| rust/bambam-gbfs/src/model/traversal/mod.rs | Updates module export from gbfs to geofence |
| rust/bambam-gbfs/src/model/traversal/geofence/* | Renames GBFS traversal components to Geofence variants |
| rust/bambam-gbfs/src/model/frontier/geofence/* | Implements new geofence constraint model with engine, service, and builder |
| rust/bambam-gbfs/Cargo.toml | Updates version to 0.2.1 and adds geo dependency |
| doc/arch/*.d2 | Adds architectural diagrams for MEP stack and walk/transit architecture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR revises the stubbed gbfs traversal model as a geofencing model, and adds a similar constraint model with a stubbed geofence testing engine + a unit test. these are wired into the available list of builders in bambam. includes a few architectural diagrams from the gbfs onboarding discussion.