Skip to content

Rjf/wire in gbfs#65

Merged
robfitzgerald merged 11 commits intomainfrom
rjf/wire-in-gbfs
Dec 18, 2025
Merged

Rjf/wire in gbfs#65
robfitzgerald merged 11 commits intomainfrom
rjf/wire-in-gbfs

Conversation

@robfitzgerald
Copy link
Copy Markdown
Collaborator

@robfitzgerald robfitzgerald commented Dec 16, 2025

this PR revises the stubbed gbfs traversal model as a geofencing model, and adds a similar constraint model with a stubbed geofence testing engine + a unit test. these are wired into the available list of builders in bambam. includes a few architectural diagrams from the gbfs onboarding discussion.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the GBFS traversal model into a geofencing constraint model. The changes rename Gbfs references to Geofence, introduce a new frontier constraint model for geofence validation, and add a geofence testing engine with unit tests. Additionally, architectural diagrams documenting the GBFS onboarding discussion are included.

Key changes:

  • Renamed GBFS traversal components to Geofence to reflect the geofencing-focused implementation
  • Added a new GeofenceConstraintModel frontier model with a stubbed geofence testing engine
  • Added unit test for the in_geofence method demonstrating point-in-polygon validation

Reviewed changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rust/bambam/src/model/builders.rs Registers the new GeofenceConstraintBuilder and GeofenceTraversalBuilder with the Compass builder inventory
rust/bambam/Cargo.toml Adds dependency on bambam-gbfs crate
rust/bambam-gbfs/src/model/traversal/mod.rs Updates module export from gbfs to geofence
rust/bambam-gbfs/src/model/traversal/geofence/* Renames GBFS traversal components to Geofence variants
rust/bambam-gbfs/src/model/frontier/geofence/* Implements new geofence constraint model with engine, service, and builder
rust/bambam-gbfs/Cargo.toml Updates version to 0.2.1 and adds geo dependency
doc/arch/*.d2 Adds architectural diagrams for MEP stack and walk/transit architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@robfitzgerald robfitzgerald merged commit a0066ad into main Dec 18, 2025
1 check passed
@robfitzgerald robfitzgerald deleted the rjf/wire-in-gbfs branch December 18, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet