Review of changes made from 0.9.1 (clean) to current by jmarrec · Pull Request #220 · NatLabRockies/openstudio-extension-gem

jmarrec · 2025-12-04T12:51:01Z

No description provided.

…ove unnecessary comments

…on management

update copyright year in LICENSE file

* update copyright year in LICENSE file * Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor gemspec to define version within OpenStudio::Extension module * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management

…ce from Gemfile (#207)

* Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management

* Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor gemspec to define version within OpenStudio::Extension module * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management * Remove comment about circular dependency in gemspec

Update CHANGELOG.md

* Feature/version 0.9.2 updates (#206) * update copyright year in LICENSE file * Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor gemspec to define version within OpenStudio::Extension module * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management * Bump version to 0.9.3, update changelog, and remove rubocop-performance from Gemfile (#207) * Merge conflicts resolved (#210) * Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management * Add local develop commits (#211) * Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management * Version management and cleanup improvements (#212) * Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor gemspec to define version within OpenStudio::Extension module * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management * Remove comment about circular dependency in gemspec * Update CHANGELOG.md --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com>

modify runner to install gems only - no updates

Version 0.9.4

* Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com>

jmarrec · 2025-12-04T12:51:59Z

openstudio-extension.gemspec

+  files = `git ls-files -z`.split("\x0")
+  if files.empty?
+    files = Dir.glob('**/*', File::FNM_DOTMATCH).select do |f|
+      File.file?(f) && !f.match(%r{^(\.git|\.bundle|pkg|coverage|doc|_yardoc|\.yardoc)/}) && !f.match(%r{^Gemfile\.lock$})
+    end
+  end
+  spec.files = files.reject do |f|


was something not working before?

I don't remember any specific reason for this change and upon further review I'm in favor of reverting it back.

jmarrec · 2025-12-04T12:52:11Z

openstudio-extension.gemspec

+  spec.add_dependency 'addressable', '>= 2.8.1'
  spec.add_dependency 'parallel', '~> 1.19.1'
-  spec.add_dependency 'regexp_parser', '2.9.0'
-  spec.add_dependency 'addressable', '2.8.1'
+  spec.add_dependency 'regexp_parser', '>= 2.9.0'


@anchapin, as mentioned before these dependencies are VERY tricky and should not be updated without considering the implications across the openstudio, openstudio measure gems, and urbanopt gems ecosystems. Let me know if you have any questions before making dependency changes. I agree with @jmarrec, please revert.

jmarrec · 2025-12-04T12:54:20Z

openstudio-extension.gemspec

-  spec.add_development_dependency 'rubocop', '1.50'
  spec.add_development_dependency 'rspec', '~> 3.9'
+  spec.add_development_dependency 'rubocop', '>= 1.50.0'
+  spec.add_development_dependency 'rubocop-performance'


We add it in #204, #206 then, remove it in #207 then it gets readded in #210, it's re-deleted in #211; and its readded in #217

I'm lost. Do we or don't we want rubocop-performance?!

We guess is that we do not, or at least don't need to.

https://github.com/NREL/openstudio-gems/blob/be228a3dc53949afb5d36c5a8c41f8830e8c2f34/openstudio-gems.gemspec#L34

I don't have a preference but it seems like removing it is likely best.

Haha, oh rubocop! Rubocop related dependencies are ok as "DEVELOPMENT" dependency only. Please don't add them as "regular" dependencies. thanks!

jmarrec · 2025-12-04T12:54:52Z

lib/openstudio/extension/runner.rb

+              # KAF: we are no longer updating dependencies here; we are installing instead. If a user already has their
+              # gems installed, it shouldn't download anything new and should save us from some unwanted dependency updates
+              run_command('bundle install', get_clean_env)


jmarrec · 2025-12-04T12:55:22Z

lib/openstudio/extension/runner.rb

 require 'open3'
 require 'openstudio'
 require 'yaml'
-require 'fileutils'


Ok, fileutils is already required on Line 7

jmarrec · 2025-12-04T12:55:40Z

lib/openstudio/extension/rake_task.rb

      attr_accessor :name, :measures_dir, :core_dir, :doc_templates_dir, :files_dir

      def initialize(*args, &task_block)
+        super


dunno if that's wanted or not. Did rubocop do that?

I can't remember if that was from rubocop or not, but I researched it now and it isn't needed since calling super just calls Ruby's default empty initializer.

https://github.com/ruby/rake/blob/21c26b2ac0c764d3448f3a20835369429cd063ba/lib/rake/tasklib.rb#L4-L12

it does nothing

jmarrec · 2025-12-04T12:55:57Z

CHANGELOG.md

+## Version 0.9.5
+* Updated to OpenStudio 3.11 and relaxed dependencies


and re-added rubocop-performance apparently

jmarrec · 2025-12-08T09:51:22Z

Gemfile

-source 'http://rubygems.org'
-
-# Specify your gem's dependencies in openstudio-extension.gemspec
+source 'https://rubygems.org'


Well, so I don't know if this is good or not. I have no issue.

See this commit 7 years ago: 761524f

Dan at the time wrote:

Https source does not work for me even on dev vpn

* Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <achapin@nrel.gov> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com>

* Hard code rubocop version to 1.50.0 * Remove rubocop performance

* Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <achapin@nrel.gov> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) * Remove parser dependency and prep for 0.9.7 (#226) * Bump version to 0.9.5 and prepare release (#217) (#219) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> * Release v0.9.6 (#223) * Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <achapin@nrel.gov> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com> * Rubocop fixes (#224) * Hard code rubocop version to 1.50.0 * Remove rubocop performance * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com> * Revert "Remove parser dependency and prep for 0.9.7 (#226)" This reverts commit a64c11c. * Remove parser and prep for v0.9.7 (#227) * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com> Co-authored-by: Assistant Bot <assistant@example.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com>

anchapin and others added 22 commits July 30, 2025 14:28

update copyright year in LICENSE file

dde5218

Update version to 0.9.2, enhance changelog, and improve code formatting

55821a6

Merge branch 'master' into update_license_year_2025

6a9c026

Refactor gemspec to define version within OpenStudio::Extension module

8a6f17e

Refactor Gemfile and gemspec to improve dependency management and rem…

2658de4

…ove unnecessary comments

Update changelog, fix rubocop offenses, and enhance gemspec for versi…

518160d

…on management

Merge pull request #204 from NREL/update_license_year_2025

7bd2604

update copyright year in LICENSE file

Bump version to 0.9.3, update changelog, and remove rubocop-performan…

5c2807b

…ce from Gemfile (#207)

Merge conflicts resolved (#210)

4968c45

* Update version to 0.9.2, enhance changelog, and improve code formatting * Refactor Gemfile and gemspec to improve dependency management and remove unnecessary comments * Update changelog, fix rubocop offenses, and enhance gemspec for version management

Merge branch 'master' into develop

7a10377

Update CHANGELOG.md

4a232ac

Merge pull request #213 from NREL/kflemin-patch-1

1ae333a

Update CHANGELOG.md

modify runner to install gems only - no updates

75d0a7f

prep version 0.9.4

b7535d2

Merge pull request #214 from NREL/dependency-handling-update

134d199

modify runner to install gems only - no updates

Merge branch 'master' into develop

73ff59d

Merge pull request #216 from NREL/develop

5ac095f

Version 0.9.4

jmarrec commented Dec 4, 2025

View reviewed changes

jmarrec commented Dec 8, 2025

View reviewed changes

anchapin and others added 2 commits December 15, 2025 01:14

Rubocop fixes (#224)

e1447cb

* Hard code rubocop version to 1.50.0 * Remove rubocop performance

anchapin mentioned this pull request Dec 16, 2025

Bump to 0.5.2 and undo broken dependency changes NatLabRockies/OpenStudio-measure-tester-gem#99

Merged

		## Version 0.9.5
		* Updated to OpenStudio 3.11 and relaxed dependencies

Conversation

jmarrec commented Dec 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants