Skip to content

Remove duplicate utility bill variables#1276

Merged
cpaulgilman merged 7 commits intopatchfrom
sam-1879-utility-bill-vars
Feb 21, 2025
Merged

Remove duplicate utility bill variables#1276
cpaulgilman merged 7 commits intopatchfrom
sam-1879-utility-bill-vars

Conversation

@cpaulgilman
Copy link
Copy Markdown
Collaborator

@cpaulgilman cpaulgilman commented Feb 12, 2025

Fixes NatLabRockies/SAM#1879

Goes with NatLabRockies/SAM#2009, see that PR for details.

@cpaulgilman cpaulgilman self-assigned this Feb 12, 2025
@cpaulgilman cpaulgilman added this to the 2024 Release Patch 1 milestone Feb 12, 2025
Copy link
Copy Markdown
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you had to change 47 test files!

@brtietz
Copy link
Copy Markdown
Collaborator

brtietz commented Feb 13, 2025

I know this is a nitpick given the current release plan, but variable changes like this should be merged into develop, not patch.

@brtietz
Copy link
Copy Markdown
Collaborator

brtietz commented Feb 13, 2025

I ran find and replace a few times to identify potential errors, and turned up the following:

image

(sys_system instead of just sys)

There were also a few hits in the PySAM examples:

image

What is the appropriate time to update those?

@cpaulgilman
Copy link
Copy Markdown
Collaborator Author

There were also a few hits in the PySAM examples:

This should be addressed in NatLabRockies/pysam#185

@cpaulgilman
Copy link
Copy Markdown
Collaborator Author

(sys_system instead of just sys)

Good find. Thanks! Should be fixed in 0de61b7.

I also noticed one other set of variables that use "system" instead of "sys" in this context:

year1_monthly_peak_wo_system
year1_monthly_use_wo_system
year1_monthly_peak_w_system
year1_monthly_use_w_system

@brtietz, is it worth changing that? These variables seem to only be used as outputs to utilityrate5, so changing their names should have no impact on other SSC/SAM code and samples, but will affect any SDK/PySAM code out in the world that refers to those outputs.

@cpaulgilman cpaulgilman merged commit 82d9c9e into patch Feb 21, 2025
8 checks passed
@cpaulgilman cpaulgilman deleted the sam-1879-utility-bill-vars branch February 21, 2025 22:56
@brtietz brtietz modified the milestones: 2024 Release Patch 1, SAM Spring 2025 Release Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annual Electricity bill with and without system duplicated for FOM and BTM systems

3 participants