Remove duplicate utility bill variables#1276
Merged
cpaulgilman merged 7 commits intopatchfrom Feb 21, 2025
Merged
Conversation
15 tasks
sjanzou
approved these changes
Feb 13, 2025
Collaborator
sjanzou
left a comment
There was a problem hiding this comment.
Sorry you had to change 47 test files!
Collaborator
|
I know this is a nitpick given the current release plan, but variable changes like this should be merged into develop, not patch. |
Collaborator
Collaborator
Author
This should be addressed in NatLabRockies/pysam#185 |
Collaborator
Author
Good find. Thanks! Should be fixed in 0de61b7. I also noticed one other set of variables that use "system" instead of "sys" in this context: @brtietz, is it worth changing that? These variables seem to only be used as outputs to utilityrate5, so changing their names should have no impact on other SSC/SAM code and samples, but will affect any SDK/PySAM code out in the world that refers to those outputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes NatLabRockies/SAM#1879
Goes with NatLabRockies/SAM#2009, see that PR for details.