Added url encoding to getLangUrl function#1542
Open
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1542 +/- ##
============================================
+ Coverage 70.08% 70.26% +0.18%
- Complexity 1658 1668 +10
============================================
Files 32 32
Lines 4272 4298 +26
============================================
+ Hits 2994 3020 +26
Misses 1278 1278
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Reasons for creating this PR
Fixes made in PR #1307 caused that changing UI language broke URLs containing colons from language change links in top bar.
Link to relevant issue(s), if any
Description of the changes in this PR
Now URLs in top bar are URL encoded (except equal sign and ampersand) and should contain only encoded colons that are not omitted.
Known problems or uncertainties in this PR
If URL contains equal signs and ampersands as values that should be escaped they are not URL encoded as should be.
Checklist
.sr-onlyclass, color contrast)