Merged
Conversation
natlibfi-psams
requested review from
a team,
NatLibFi-JoonaKupe and
natlibfi-burger
NatLibFi-JoonaKupe
approved these changes
Feb 17, 2026
NatLibFi-JoonaKupe
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the way the application selects magazine API and reader URLs based on the environment. Instead of relying solely on
NODE_ENV, it usesNEXT_PUBLIC_MAGAZINES_ENV.Changes:
NEXT_PUBLIC_MAGAZINES_ENVindocker-compose.ymlto explicitly set the magazines environment (productionorplayground).getMagazineReaderUrlandgetMagazineApiUrlinsrc/config/magazines.tsto useNEXT_PUBLIC_MAGAZINES_ENVvariable if set, falling back toNODE_ENVas before. This makes it easier to test different environments without changing the overall app environment.