Closed
Conversation
Contributor
nvolk
commented
Mar 4, 2026
nvolk
commented
- Jotain osakohteiden tunnisteiden vertailuja (773$x ja $z, ei vielä $o, kun en osannut siitä päättää, että miten suhtautua eri arvoihin, sillä $o:issa lienee enempi huojuntaa)
- julkaisuvuosikoodin laajentamista (008/07-10 -> 008/06-15) ja parempaa tukea puuttuville arvoille
Handle sami languages etc
…s 008/07-10) in code and tests
ammsalme
reviewed
Mar 4, 2026
|
|
||
| function getSruSearchType() { | ||
| if (relevantSubfieldCode === ISBN) { | ||
| return 'index.bath.isbn'; |
ammsalme
reviewed
Mar 4, 2026
| return 'index.bath.isbn'; | ||
| } | ||
| if (relevantSubfieldCode === ISSN) { | ||
| return 'index.bath.issn'; |
ammsalme
reviewed
Mar 4, 2026
| if (relevantSubfieldCode === ISSN) { | ||
| return 'index.bath.issn'; | ||
| } | ||
| return 'whatever.whatever'; // 773$o not really supported |
Contributor
There was a problem hiding this comment.
Could work with dc.identifier, maybe
ammsalme
reviewed
Mar 4, 2026
| reject(err); | ||
| } | ||
| }) | ||
| .on('record', record => { |
Contributor
There was a problem hiding this comment.
What happens if we get several records as response?
(sourceids shouldn't hit several records, ISBNs and ISSNs propably will)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.