chore: cleaning + major versions upgrade

[SRWieZ]

Summary of changes

• Removed old vue dependencies
• Removed stall files in dist/ from previous plugin builds (added rimraf before building plugin)
• Fixed some type return in window.ts
• Major version upgrade npm outdated:
  • vite v4 to v5
  • typescript v4 to v5
  • stylelint v14 to v16
  • prettier v2 to v3
  • eslint v8 to v9
  • electron-builder v24 to v25
  • electron-chromedriver v31 to v32
  • electron-context-menu v3 to v4
  • get-port v5 to v7
  • electron v31 to v32

Every commit is checked with (native:serveand native:build)

• ✅ (typescript, vite, jest, eslint, electron-chromedriver, prettier) 1f38d64
• ✅ ESLint upgraded, migrated but not applied 54b83e0
• ✅ ESM migration: 825c342 245252f
• ✅ Update of get-port, electron, electron-store and electron-context-menu 84f86e1 bb72311 df6fcbf

Upgrades to the last version of electron and vite blocked by

• menubar: chore(deps): update to electron 34.x.x max-mapper/menubar#486
• electron-vite: Vite 6 support alex8088/electron-vite#673

About the ESM upgrade:
More and more packages becomes ESM only. Electron supports ESM since v28. Here is some links to read for a better understanding:

• Pure ESM package: https://github.com/sindresorhus/electron-store/releases/tag/v9.0.0
• Pure ESM Package: https://github.com/sindresorhus/get-port/releases/tag/v6.0.0
• Pure ESM Package: https://github.com/sindresorhus/electron-context-menu/releases/tag/v4.0.0
• Gist explaining the steps to migrate and why it became a nightmare to maintain two versions of the same library. https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
• TypeScript and ESM: https://www.typescriptlang.org/docs/handbook/modules/reference.html
• Electron ESM support: https://www.electronjs.org/docs/latest/tutorial/esm
• Jest ESM support: https://jestjs.io/docs/ecmascript-modules
• Electron Vite support: https://electron-vite.org/guide/dev#migrating-to-esm

[SRWieZ]

WIP. Current state of npm outdated

Before & after

[SRWieZ]

Finished and ready to be tested ! 🎉

With this PR, we are up to date! We are only one version behind Electron and Vite.

I tested this PR with many of my apps without any problem.

There is one small irony:
The Jest tests I fixed here #148 are now broken.

I tried every other tutorial on the internet, and I don't understand why it doesn't mock electron. But to be fair, the tests haven't been working for a long time and are not testing the app fairly enough.

My suggestion is to migrate to vitest, which supports ESM modules out of the box and has a compatible syntax (it, test, describe, etc...). Maybe even make tests with electron rendered?

Post scriptum:
Intel Mac users, you may notice the following error in your console, which can be ignored:
EGL Driver message (Error) eglQueryDeviceAttribEXT: Bad attribute. electron/electron#43415
The solution is to either wait or disable GPU acceleration. So be patient.

Final result 😎

Happy holidays to everyone! 🎊

[SRWieZ]

Hold on to that, I found an error.

[SRWieZ]

Fixed!

I didn't pay enough attention to the Electron ESM documentation. preload.js wasn't preloading.

I'm developing all my apps with the "dev-main" requirement, so I noticed this issue in another app where I'm heavily using Livewire events.

[SRWieZ]

I missed the build/notarize.js file, which my IDE completely hid from me. 🙄

I don't know why, but I cannot remove this directory from the excluded ones in PhpStorm. I also wonder if I'm the only one facing this issue. If not, we should probably rename this directory.

Anyway, I confirm that I can still build and use my app as before.

[simonhamp]

There are some conflicts here which need to be resolved since I've merged #149.

It seems to be mostly around file names.... do we need the .js extensions on the imports now for some reason?

Could you take a look when you get chance?

[SRWieZ]

Yes, I can.

Can you merge #148 first? I will have a conflict with it as well.

This PR modifies all files, so the more pull requests you merge beforehand, the easier it will be to resolve conflicts at once.

[SRWieZ]

Rebased on main.

The minimum required node version is 20.

• Bumped on GitHub Actions
• Bumped on package.json

It seems to be mostly around file names.... do we need the .js extensions on the imports now for some reason?

Yes we have to. It's explained here and here

[simonhamp]

That failing to run the plugin test suite concerns me...

[SRWieZ]

I was planning to look into that after this one is merged.

I don't think I can make it work in jest. It's clearly a module resolution problem, and I have tried every other way before giving up.

I can explore the vitest approach if you want, here or in another PR.

[SRWieZ]

Obviously, I don't give up on the testing suite.

As you have seen with my previous PR, I think it's important to have a solid one.

It's just that with jest, I tried lots of different suggestions, and it's already hard to make it work well with TypeScript; it's worth it with ESM.

I really think we have a good chance with vitest if we believe the homepage (and some Stack Overflow users).

From https://vitest.dev:

• Vite Powered: Reuse Vite's config and plugins - consistent across your app and tests. But it's not required to use Vitest!
• Jest Compatible: Expect, snapshot, coverage, and more - migrating from Jest is straightforward.
• Smart & instant watch mode: Only rerun the related changes, just like HMR for tests!
• ESM, TypeScript, JSX: Out-of-the-box ESM, TypeScript, and JSX support powered by esbuild.

[simonhamp]

I managed to make some progress on getting the test suite running...

The failures seem to be related to the upgrades... maybe Vitest will handle all of this a little better, I don't know...

I'm going to approve this for now as I've been able to manually validate that things are still working (tho I suspect there may be some gremlins hidden away) and we can explore Vitest in a separate PR, and another one with my "fixes" for this test suite

[SRWieZ]

Cool! 🎉

We'll find the gremlins before tagging.

I'm going to pass all my apps to require "dev-main"

---

I tried the node --experimental-require-module node_modules/jest/bin/jest.js way too without success.

That would be included in node23 by the way.

Also this mode broke PHPStorm tests. I'm sure it's just a matter of configuring the experimental mode but it's better for contributors if it just work out of the box.

[SRWieZ]

electron-vite has tagged 3.0-beta, which supports Vite v6 & Electron <= 34

https://github.com/alex8088/electron-vite/releases/tag/v3.0.0-beta.0