Pre & Post Build Command Support #167
Conversation
|
Great work on this as always Pete! I've added two comments, but honestly this comes down to preference I think. If @SRWieZ is okay with it I am too. I have a question though. I might not be understanding fully how this works so please bear with me. Isn't this a question of looping through all the prebuild & postbuild commands & running them? The clever Can you elaborate on why it works like this? |
|
Updated, refactored and simplified. The scope creep was real. |
| ->with([ | ||
| // Empty class with the HasPreAndPostProcessing trait | ||
| new class | ||
| { | ||
| use HasPreAndPostProcessing; | ||
| }, | ||
| ]); |
I did consider this and thought it could be creeping. It may also be that you're fine with things failing in the pre or post steps. Definitely discussion worthy and can be revisited if decided we should. |
PeteBishwhip
deleted the
feature/493-second-pass-pre-post-build-config
branch
3 participants
Config key defaults provided in NativePHP/laravel#496
This pull request introduces a new trait for handling pre- and post-processing commands in the build process, along with updates to the
BuildCommandclass and associated tests. The most important changes include adding theHasPreAndPostProcessingtrait, updating theBuildCommandto use this trait, and adding tests to ensure the trait works correctly.New Trait for Pre- and Post-Processing:
src/Traits/HasPreAndPostProcessing.php: Introduced theHasPreAndPostProcessingtrait to handle pre- and post-processing commands during the build process. This includes methods for executing commands and retrieving configuration.Updates to BuildCommand:
src/Commands/BuildCommand.php: Updated theBuildCommandclass to use the newHasPreAndPostProcessingtrait and added calls topreProcessandpostProcessmethods in thehandlemethod. [1] [2] [3]Tests for the New Trait:
tests/Mocks/HasPreAndPostProcessingMock.php: Added a mock class to facilitate testing of theHasPreAndPostProcessingtrait.tests/Unit/Traits/HasPreAndPostProcessingTest.php: Added unit tests to verify that thepreProcessandpostProcessmethods execute commands as expected based on configuration.Development Dependency:
composer.json: Addedmockery/mockeryas a development dependency for testing purposes.Closes #493