Chore/update dependencies #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRWieZ
approved these changes
Jul 19, 2025
|
It doesn't look like any forks are regularly updated. There is a PR open to update to 34, but it has been silent for a while Def preferable not to pull this package in considering the maintenance burden. I'll see if they'll accept a PR. |
|
Dammit. That package is a PITA. We may need to come up with an alternative. I don't think it's especially complex. I wouldn't fork it tho, just pull the logic straight in |
|
We can fork it but with a big warning that's it's only supposed to used in NativePHP. No support. Until there is a maintained fork upstream. |
|
Shall we merge this & create another PR for the menubar dependency & electron itself? |
|
I vote yes |
|
Cool! I need one more review to merge @NativePHP/contributors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies. NativePHP/laravel#390
I wanted to upgrade Electron as well but we're locked to v33 for now since a package we're depending on hasn't been updated for a while: https://github.com/max-mapper/menubar
Updates to production dependencies:
body-parserto version^2.2.0from^1.20.3.expressto version^5.1.0from^4.21.2.Updates to development dependencies:
electron-builderto version^26.0.19from^26.0.14.electron-viteto version^4.0.0from^3.0.0.viteto version^7.0.5from^6.2.1.Furthermore it has to be noted that there are some breaking changes when we are able to upgrade electron (
33->37)https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-340
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-350
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-360
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-370
Most notably dropping support for macOS Catalina & changes in menubar behavior.