Skip to content

Fixed Tests #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2024
Merged

Fixed Tests #362

merged 1 commit into from
Sep 8, 2024

Conversation

RobertWesner
Copy link
Contributor

  • Some tests failed due to new features.
  • A few assertions were incorrect.
  • Native\Laravel\Windows\Window::toArray() now contains transparent
  • Tests that call Window::open() were changed to not use PendingOpenWindow as it causes failing API calls

@simonhamp
Copy link
Member

Awesome. Thank you 🙏🏼

@simonhamp simonhamp merged commit cc11ceb into NativePHP:main Sep 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonhamp simonhamp simonhamp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RobertWesner @simonhamp