Skip to content

Conversation

danielpetrica
Copy link
Contributor

@danielpetrica danielpetrica commented Sep 29, 2024

This commits adds the skip links option to avoid the lack of support for symbolic links in the underlying flysystem library. This fixes issue https://github.com/orgs/NativePHP/discussions/374 but I'll leave it on draft as I want to test it on a different system too.

Why we need to skip symlinks ?

One classic example that may brake this is the symlinked desktop directory for backups to Onedrive.
I haven't tryid one drive specifically but on my Linux machine my desktop folder and a bunch o other folders links to nextcloud directories so they break the driver system.

Drawbacks

Users can't see symlinked folders (like the desktop folder in the above example), but they can see them if they are defined as root folder.

Testing:

  • Linux
  • Mac
  • Windows ( I don't have a windows machine to test it)

@danielpetrica
Copy link
Contributor Author

I'll leave it as draft to be able to test it on mac first

@danielpetrica
Copy link
Contributor Author

this works with mac too. But if you try to list all directories recursivelly inside user it still get's an error on special directories like photo library and Applications. Don't know if it's possible to filter them when doing Storage::disk("user_home")->allFiles();

@danielpetrica danielpetrica marked this pull request as ready for review September 30, 2024 09:13
@simonhamp simonhamp merged commit 23c78e2 into NativePHP:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants