Fix some DB stuff #413

simonhamp · 2024-11-15T11:32:54Z

Off the back of #408, some other issues came to light.

native:migrate call doesn't work inside the service provider due to the command not actually being resolved yet
Configuring WAL mode only makes sense if we definitely have a DB to run those statements against
When removing the database (using native:migrate:fresh), we should clean up the SQLite WAL-mode files
Bonus: the exception handler is redundant and shouldn't run when we're not in a running NativePHP app context

simonhamp added 4 commits November 15, 2024 11:23

Resolve native:migrate command so we can call it

d728712

Only run exception handler in native context

e7cd9c6

Only configure DB if we have one

0b15d4d

Silently unlink all SQlite files

563345b

simonhamp mentioned this pull request Nov 15, 2024

Fix migrations when database does not exist #412

Closed

simonhamp merged commit a3bd955 into main Nov 15, 2024
2 of 23 checks passed

simonhamp deleted the fix/db-stuff branch November 15, 2024 11:36

Provide feedback