Skip to content

fix: child process cmd: option except iterable array #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2024
Merged

fix: child process cmd: option except iterable array #429

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ededd88
fix: child process cmd: option except iterable array
SRWieZ Nov 21, 2024
e07c964
fix: throw an exception if $cmd is not an indexed array
SRWieZ Nov 22, 2024
539e875
fix: array_values but with a hint for static analyzer
SRWieZ Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/ChildProcess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ public function start(
?array $env = null,
bool $persistent = false
): static {
$cmd = $this->ensureCmdIsAnIndexedArray($cmd);

$process = $this->client->post('child-process/start', [
'alias' => $alias,
'cmd' => (array) $cmd,
'cmd' => $cmd,
'cwd' => $cwd ?? base_path(),
'env' => $env,
'persistent' => $persistent,
Expand All @@ -72,9 +73,11 @@ public function start(

public function php(string|array $cmd, string $alias, ?array $env = null, ?bool $persistent = false): self
{
$cmd = $this->ensureCmdIsAnIndexedArray($cmd);

$process = $this->client->post('child-process/start-php', [
'alias' => $alias,
'cmd' => (array) $cmd,
'cmd' => $cmd,
'cwd' => $cwd ?? base_path(),
'env' => $env,
'persistent' => $persistent,
Expand Down Expand Up @@ -132,4 +135,15 @@ protected function fromRuntimeProcess($process): static

return $this;
}

protected function ensureCmdIsAnIndexedArray(string|array $cmd): array
{
if (is_string($cmd)) {
return [$cmd];
}

if (array_keys($cmd) !== range(0, count($cmd) - 1)) {
throw new \InvalidArgumentException('Only indexed arrays are supported for the cmd: argument.');
}
}
}
Loading