Skip to content

feat: phpstan level 5 #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Dec 19, 2024
Merged

feat: phpstan level 5 #446

merged 21 commits into from
Dec 19, 2024

Conversation

@SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Dec 12, 2024 •
edited
Loading

Put the entire project through PHPStan level 5.

  • Found some bugs that are now fixed.
  • I made one change per commit and recommend keeping them, even though I had some trouble understanding one test bench error. 😅
  • One fix is duplicated from Fixes and improvements to powerMonitor #445, but it shouldn't cause any merge issues.
  • I don't know why static analysis won't be applied to this PR.
  • Added a composer qa script to ensure code quality assurance.
  • There is an alternative to 585fb47, but it would involve breaking changes. Unfortunately, asymmetrical visibility has only been available since PHP 8.4.

SRWieZ added 19 commits December 12, 2024 10:47
@SRWieZ
feat: phpstan level 5
933c8e5
@SRWieZ
fix: $database undefined
91c5275
@SRWieZ
fix: Unsafe usage of new static()
5be8381
@SRWieZ
fix: ignore NativeAppServiceProvider not existing
f009309
@SRWieZ
fix: FreshCommand constructor invoked with 1 parameter, 0 required
cc1cb87
@SRWieZ
fix: MenuBuilder facade function duplicates and arguments
03bd832
@SRWieZ
fix: Type void cannot be part of a union type declaration.
3c7e958
@SRWieZ
fix: Php compactor missing imports and return statement
f0a5baf
@SRWieZ
fix: missing SeedDatabaseCommand@handle return statement
7ebe7f9
@SRWieZ
Fix: cannot assign a value to a public readonly property outside of t…
585fb47 
…he constructor
@SRWieZ
Fix: PowerMonitor invoked Client::get() with 2 parameters, 1 required
8fb93e9
@SRWieZ
fix: alternative for FreshCommand migrator argument
cac9ea1
@SRWieZ
Revert "fix: alternative for FreshCommand migrator argument"
7aa74f1 
This reverts commit cac9ea1.
@SRWieZ
Revert "fix: FreshCommand constructor invoked with 1 parameter, 0 req…
d1a90f4 
…uired"

This reverts commit cc1cb87.
@SRWieZ
fix: trying something
6b88d13
@SRWieZ
fix: phpstan.yml
36ff261
@SRWieZ
Revert "fix: trying something"
c3c2e63 
This reverts commit 6b88d13.
@SRWieZ
fix: trying to lower the minimum laravel 10 dependency
2ce6334
@SRWieZ
fix: final fix 🎉
b9dc748
@SRWieZ SRWieZ marked this pull request as ready for review December 12, 2024 11:15
@SRWieZ
Copy link
Member Author

SRWieZ commented Dec 12, 2024

Ready for review!

simonhamp
simonhamp reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one real concern here, but I can potentially be persuaded 😂

@SRWieZ
Copy link
Member Author

SRWieZ commented Dec 18, 2024

Ready!

@simonhamp simonhamp merged commit 1a8151f into NativePHP:main Dec 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonhamp simonhamp simonhamp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SRWieZ @simonhamp