V1 docs #111

shanerbaner82 · 2025-04-29T02:30:26Z

No description provided.

PeteBishwhip

Just a few comments and questions. Overall looks good. The URL's in deep-links are my biggest concern. Perhaps we should be using example.net instead?

PeteBishwhip · 2025-04-29T08:21:58Z

resources/views/docs/mobile/1/getting-started/installation.md

-### Laravel
+#### For Windows
+```shell
+set JAVA_HOME=C:\Program Files\Microsoft\jdk-17.0.8.7-hotspot


I'm wondering if this can be replaced with a programatic approach? I'm not sure everyone will have 17.0.8.7 specifically? Not a blocker, just an observation.

Is it possible this isn't required if JAVA_HOME is already set in the Windows Env Variables?

resources/views/docs/mobile/1/getting-started/installation.md

PeteBishwhip · 2025-04-29T08:36:46Z

resources/views/docs/mobile/1/the-basics/deep-links.md

+
+For example:
+```dotenv
+https://bifrost.tech/property/456


Where did this URL come from? Accessing it shows "Domain for Sale".

PeteBishwhip · 2025-04-29T08:38:49Z

resources/views/docs/mobile/1/the-basics/dialogs.md

-Dialog::alert('Title', 'Message', $buttons, fn ($selected) => {
-    echo "You selected {$buttons[$selected]}";
-});
+Dialog::alert('Title', 'Message');


Have we dropped support for buttons on the alerts?

@simonhamp and I are still discussing the best way vs the immediate way forward on this one.

SRWieZ

Looking good!

I added some notes here and there ^^

SRWieZ · 2025-04-29T09:47:23Z

resources/views/docs/mobile/1/getting-started/installation.md

+
+NativePHP for mobile is built to work with Laravel. You can install it into an existing Laravel application, or
+[start a new one](https://laravel.com/docs/installation). The most painless way to get PHP and Node up and running on your system is with
+[Laravel Herd](https://herd.laravel.com). It's fast and free!

 ## Private package


I think I will merge the Private package and Install NativePHP for mobile sections.

SRWieZ · 2025-04-29T09:49:02Z

resources/views/docs/mobile/1/getting-started/development.md

+After running:
+
+```bash
+php artisan native:install


Since it references the command and we don't need to run it in this part of the documentation. I will use an inline code block instead of a full code block.

SRWieZ · 2025-04-29T09:51:10Z

resources/views/docs/mobile/1/the-basics/system.md

@@ -21,35 +21,35 @@ about whether a particular feature is specific to iOS or Android.

 Most of the system-related features are available through the `System` facade.

+## Synchronous vs. Asynchronous Methods


I'm not sure Synchronous vs. Asynchronous Methods belongs here. Maybe it should have its own page, even if it's a short one.

SRWieZ · 2025-04-29T09:52:41Z

resources/views/docs/mobile/1/the-basics/system.md

@@ -58,11 +58,13 @@ You may vibrate the user's device by calling the `vibrate` method:
 System::vibrate()
 ```

+_Coming Soon_ Options: `duration` and `intensity` 
+
 ## Push Notifications


Push notifications should have their own dedicated page, and should contain an installation and configuration guide for FCM and APN.

gwleuverink · 2025-04-29T19:29:51Z

resources/views/docs/mobile/1/getting-started/installation.md

-4. An active [Apple Developer account](https://developer.apple.com/)
-5. [A NativePHP for iOS license](https://checkout.anystack.sh/nativephp-ios)
-6. _Optional_ iOS device
+3. [A NativePHP for mobile license](https://checkout.anystack.sh/nativephp-ios)


Possible wrong link also as mentioned by Pete

gwleuverink · 2025-04-29T23:15:43Z

resources/views/docs/mobile/1/the-basics/system.md

@@ -81,29 +83,6 @@ if ($token = System::getPushNotificationsToken()) {
 Once you have the token, you may use it from your server-based applications to trigger Push Notifications directly to


This raised a couple of questions:

Should these tokens be stored on the server?

Could a user (on the server) have multiple tokens associated with it if they use multiple devices?

How to handle tokens when a user logs out and logs back in on with a different account on the device?

Can you give a brief explainer on what's involved to handle messages server side?

gwleuverink · 2025-04-29T23:20:54Z

Oh boy just a couple more days guys! This looking great already

PeteBishwhip

I'm good with it as-is with one comment on use of Windows in a comment. But thats not a blocker in my opinion at all. Nice work Shane.

PeteBishwhip · 2025-04-30T13:05:23Z

resources/views/docs/mobile/1/getting-started/installation.md

+
+#### For macOS
+```shell
+export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in the Windows Env Variables


Suggested change

export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in the Windows Env Variables

export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in your system Environment Variables.

I believe it's the same for Mac, so likely no need to reference Windows specifically. :)

Covered

simonhamp

I made a few minor edits to clean some stuff up a bit, but otherwise this is looking great! Awesome work @shanerbaner82 🙌🏼

SHIP IT

shanerbaner82 added 3 commits April 28, 2025 22:25

First pass at docs

cf223d5

Merge branch 'main' into v1-docs

902415a

Update v1 alert

cda319e

shanerbaner82 requested review from simonhamp, SRWieZ, PeteBishwhip and gwleuverink April 29, 2025 02:30

shanerbaner82 added 2 commits April 28, 2025 23:12

cleanup and nfc/deeplink docs

d595a8b

remove coming soon items

b820ceb

PeteBishwhip requested changes Apr 29, 2025

View reviewed changes

SRWieZ previously requested changes Apr 29, 2025

View reviewed changes

gwleuverink previously requested changes Apr 29, 2025

View reviewed changes

shanerbaner82 added 2 commits April 30, 2025 08:53

updates docs for v1

543cf67

Merge branch 'main' into v1-docs

44747bc

shanerbaner82 requested review from gwleuverink, SRWieZ and PeteBishwhip April 30, 2025 13:00

PeteBishwhip approved these changes Apr 30, 2025

View reviewed changes

Updates

d9b550b

Cleanup

1c0518a

simonhamp approved these changes Apr 30, 2025

View reviewed changes

shanerbaner82 merged commit 23fc2a2 into main Apr 30, 2025
1 check passed

shanerbaner82 deleted the v1-docs branch April 30, 2025 20:21

		@@ -21,35 +21,35 @@ about whether a particular feature is specific to iOS or Android.

		Most of the system-related features are available through the `System` facade.

		## Synchronous vs. Asynchronous Methods

		@@ -81,29 +83,6 @@ if ($token = System::getPushNotificationsToken()) {
		Once you have the token, you may use it from your server-based applications to trigger Push Notifications directly to

	export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in the Windows Env Variables
	export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in your system Environment Variables.

Uh oh!

V1 docs #111

V1 docs #111

Uh oh!

Conversation

shanerbaner82 commented Apr 29, 2025

Uh oh!

PeteBishwhip left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SRWieZ left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gwleuverink commented Apr 29, 2025

Uh oh!

PeteBishwhip left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simonhamp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SRWieZ left a comment •

edited

Loading