Skip to content

Conversation

shanerbaner82
Copy link
Contributor

No description provided.

@shanerbaner82 shanerbaner82 self-assigned this May 1, 2025
Copy link
Contributor

@gwleuverink gwleuverink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: add env variables before deployment

@steven-fox
Copy link
Collaborator

I think adding sentry for unhandled exceptions and as a logging provider will produce duplicate exception entries in sentry?

https://docs.sentry.io/platforms/php/guides/laravel/usage/#log-channels

@shanerbaner82
Copy link
Contributor Author

Todo: add env variables before deployment

Already on the server

@shanerbaner82
Copy link
Contributor Author

I think adding sentry for unhandled exceptions and as a logging provider will produce duplicate exception entries in sentry?

https://docs.sentry.io/platforms/php/guides/laravel/usage/#log-channels

removed, good call

@steven-fox
Copy link
Collaborator

Gets my approval. Ship it!

@shanerbaner82
Copy link
Contributor Author

Gets my approval. Ship it!

You can't approve?

@steven-fox
Copy link
Collaborator

Gets my approval. Ship it!

You can't approve?

Negative. Can handle those permissions later.

@shanerbaner82 shanerbaner82 merged commit f3bee74 into main May 1, 2025
1 check passed
@shanerbaner82 shanerbaner82 deleted the add-sentry branch May 1, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants