Skip to content

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented May 12, 2025

The new .github/workflows/tests.yaml workflow supports unit and feature tests, using Composer dependency caching and an in-memory SQLite database. It compiles assets and generates an application key before test execution.

The composer.json now includes doctrine/dbal (version ^3.9) because otherwise it would not migrate on my machine.

@SRWieZ
Copy link
Member Author

SRWieZ commented May 12, 2025

@simonhamp @steven-fox any idea why the tests don't pass?

I tried passing default values to STRIPE_* keys in my .env, and it still doesn't pass on my Mac.

@steven-fox
Copy link
Collaborator

@simonhamp @steven-fox any idea why the tests don't pass?

I tried passing default values to STRIPE_* keys in my .env, and it still doesn't pass on my Mac.

I think you're on the right issue - this is probably a env key problem (anystack keys included).

Let me pull this branch and see if I can tweak things to get it working in a sensible manner. The tests were admittedly done with haste as the priority, so taking a moment to set things up differently is probably warranted.

@steven-fox steven-fox force-pushed the feature/tests-workflow branch from 1ac64ab to 6128cb0 Compare May 12, 2025 14:47
@steven-fox
Copy link
Collaborator

@SRWieZ I added testing env vars to phpunit.xml and the workflow is now working correctly.

Thanks!

@steven-fox steven-fox merged commit 2f64758 into main May 12, 2025
2 checks passed
@steven-fox steven-fox deleted the feature/tests-workflow branch May 12, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants