feat: add angular 19 support #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanKelly369
approved these changes
Dec 12, 2024
SeanKelly369
approved these changes
Dec 17, 2024
SeanKelly369
left a comment
SeanKelly369
left a comment
There was a problem hiding this comment.
Looks fine, but there only one way to find out, merge it and test it.
| elRef: ElementRef, | ||
| viewUtil: ViewUtil, | ||
| private environmentInjector: EnvironmentInjector | ||
| private environmentInjector: EnvironmentInjector, |
There was a problem hiding this comment.
It's not by an means a show stopper, but the , character has been added in a few places where it wasn't needed. It won't prevent the code from compiling, therefore it isn't an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.