fix: prevent crash during debug on fast view churn (like with HMR) #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case surfaced when doing fast HMR changes with Vite. During debug/development, these are benign and just due to race condition on js objects outliving their native wrapper very briefly. This just allows for quality of life debugging with fast HMR changes. Standard assert behavior is unchanged for release builds.
The small adjustment on
IndexedPropertySetterCallback
is a small related issue but important bugfix.Original code:
if (wrapper == nullptr && wrapper->Type() != WrapperType::ObjCObject) { return; }
This is problematic because:
It can dereference wrapper when it’s null (the RHS of && is evaluated when the LHS is true).
The logic there was wrong: it only returns when both are true. If wrapper is non-null but not an ObjCObject, it wouldn’t return and would proceed with an incompatible wrapper.
Fixed code:
if (wrapper == nullptr || wrapper->Type() != WrapperType::ObjCObject) { return; }
This is the intended guard: