fix: prevent global Promise overwrite for thread safety. #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures thread safety for Promises by preventing the global
Promiseobject from being overwritten by user-space code or 3rd party libraries.NativeScript relies on a custom Promise proxy implementation to ensure that callbacks are executed on the same thread where they were created. This is critical for iOS, where UI updates must happen on the main thread.
Some JavaScript libraries (e.g., Mocha) attempt to replace the global
Promisewith their own implementation or polyfill. If this happens, the runtime's thread marshalling logic is lost, leading to deadlocks, race conditions, or crashes when callbacks run on the wrong thread.This change wraps
globalThisin a Proxy during initialization to intercept and silently block any attempts to redefine or assign to thePromiseproperty, strictly preserving the runtime's thread-safe implementation.Note: This has been battle-tested since Nov 2020 in a project I work on.