Adopt the react-native-node-api standard Node-API module structure #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built with: ```sh ./build_all_ios.sh --no-engine --embed-metadata ```
shirakaba
changed the title
react-native-node-api standard approach to arranging Node-API modules for platforms other than non-Node.jsreact-native-node-api standard approach (for arranging Node-API modules for platforms other than non-Node.js)
shirakaba
changed the title
react-native-node-api standard approach (for arranging Node-API modules for platforms other than non-Node.js)react-native-node-api standard Node-API module structure
shirakaba
changed the title
react-native-node-api standard Node-API module structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR refactors the npm packages to distribute the iOS
NativeScript.xcframeworkin a standard shape that will work on React Native, as detailed by the prebuild specification.Repo structural changes
A summary of the main changes:
You'll see I've ensured that the top-level package
@nativescript/ioscontinues to includeNativeScript.xcframeworkas before. So this change mainly affects the@nativescript/ios-node-apipackage.I've not touched the macOS side of things, as
@nativescript/macos-node-apialready works fine on Node.js as-is. The only motivation to change it would be to extend support toreact-native-macos, but as very few people use that, it's not my immediate priority.packages/ios/build/Release/NativeScript.apple.nodebuilt with: