chore: fix PR comments

Author: Fatme

lib/declarations.d.ts

@@ -841,7 +841,7 @@ interface IDeployCommandHelper {
 interface IBundleValidatorHelper {
 	/**
 	 * Validates bundling options.
-	 * In case when minSupportedVersion is provided, gets the current version of nativescript-dev-webpack from package json and compares with the provided version.
+	 * In case when minSupportedVersion is provided, gets the current version of nativescript-dev-webpack from package.json and compares with the provided version.
 	 * @param {string} minSupportedVersion the minimum supported version of nativescript-dev-webpack
 	 * @return {void}
 	 */

lib/helpers/bundle-validator-helper.ts

@@ -16,17 +16,17 @@ export class BundleValidatorHelper implements IBundleValidatorHelper {
 	public validate(minSupportedVersion?: string): void {
 		if (this.$options.bundle) {
 			const bundlePluginName = this.bundlersMap[this.$options.bundle];
-			const hasBundlerPluginAsDependency = this.$projectData.dependencies && this.$projectData.dependencies[bundlePluginName];
-			const hasBundlerPluginAsDevDependency = this.$projectData.devDependencies && this.$projectData.devDependencies[bundlePluginName];
-			if (!bundlePluginName || (!hasBundlerPluginAsDependency && !hasBundlerPluginAsDevDependency)) {
+			const bundlerVersionInDependencies = this.$projectData.dependencies && this.$projectData.dependencies[bundlePluginName];
+			const bundlerVersionInDevDependencies = this.$projectData.devDependencies && this.$projectData.devDependencies[bundlePluginName];
+			if (!bundlePluginName || (!bundlerVersionInDependencies && !bundlerVersionInDevDependencies)) {
 				this.$errors.fail(BundleValidatorMessages.MissingBundlePlugin);
 			}
 
 			if (minSupportedVersion) {
-				const currentVersion = hasBundlerPluginAsDependency || hasBundlerPluginAsDevDependency;
+				const currentVersion = bundlerVersionInDependencies || bundlerVersionInDevDependencies;
 				const isBundleSupported = semver.gte(semver.coerce(currentVersion), semver.coerce(minSupportedVersion));
 				if (!isBundleSupported) {
-					this.$errors.fail(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion));
+					this.$errors.failWithoutHelp(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion));
 				}
 			}
 		}

test/helpers/bundle-validator-helper.ts

@@ -22,15 +22,16 @@ function createTestInjector(options: { dependencies?: IStringDictionary, devDepe
 		devDependencies: options.devDependencies
 	});
 	testInjector.register("errors", {
-		fail: (err: string) => error = err
+		fail: (err: string) => error = err,
+		failWithoutHelp: (err: string) => error = err
 	});
 	testInjector.register("options", ({ bundle: "webpack" }));
 	testInjector.register("bundleValidatorHelper", BundleValidatorHelper);
 
 	return testInjector;
 }
 
-describe.only("BundleValidatorHelper", () => {
+describe("BundleValidatorHelper", () => {
 	beforeEach(() => error = null);
 
 	let testCases: ITestCase[] = [
@@ -52,25 +53,32 @@ describe.only("BundleValidatorHelper", () => {
 					expectedError: null
 				},
 				{
-					name: `should not throw an error when webpack's version is grather than minSupportedVersion in case when webpack is installed as ${key}`,
+					name: `should not throw an error when webpack's version is greater than minSupportedVersion when webpack is installed as ${key}`,
 					isDependency,
 					currentWebpackVersion: "0.13.1",
 					minSupportedWebpackVersion: "0.13.0",
 					expectedError: null
 				},
 				{
-					name: `should not throw an error when webpack's version is equal to minSupportedVersion in case when webpack is installed as ${key}`,
+					name: `should not throw an error when webpack's version is equal to minSupportedVersion when webpack is installed as ${key}`,
 					isDependency,
 					currentWebpackVersion: "0.10.0",
 					minSupportedWebpackVersion: "0.10.0",
 					expectedError: null
 				},
 				{
-					name: `should throw an error when webpack's version is lower than minSupportedVersion in case when webpack is installed as ${key}`,
+					name: `should throw an error when webpack's version is lower than minSupportedVersion when webpack is installed as ${key}`,
 					isDependency,
 					currentWebpackVersion: "0.17.0",
 					minSupportedWebpackVersion: "0.18.0",
 					expectedError: format(BundleValidatorMessages.NotSupportedVersion, "0.18.0")
+				},
+				{
+					name: `should not throw an error when prerelease version of webpack is installed as ${key}`,
+					isDependency,
+					currentWebpackVersion: "0.17.0-2018-09-28-173604-01",
+					minSupportedWebpackVersion: "0.17.0",
+					expectedError: null
 				}
 			]);
 		});