Skip to content

feat(doctor): add api 33 as supported #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2022
Merged

feat(doctor): add api 33 as supported #5684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8f15a0
feat(doctor): add android-33 to supported sdks
rigor789 Jul 25, 2022
a57813f
chore: update api-level to version map
rigor789 Jul 25, 2022
3ccf649
chore(release): @nativescript/doctor 2.0.9
rigor789 Jul 25, 2022
893989b
feat: bump @nativescript/doctor version
rigor789 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/common/mobile/emulator-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { injector } from "../yok";
export class EmulatorHelper implements Mobile.IEmulatorHelper {
// https://developer.android.com/guide/topics/manifest/uses-sdk-element
public mapAndroidApiLevelToVersion = {
"android-33": "13.0.0",
"android-32": "12.0.0",
"android-31": "12.0.0",
"android-30": "11.0.0",
"android-29": "10.0.0",
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"mobile"
],
"dependencies": {
"@nativescript/doctor": "2.0.8",
"@nativescript/doctor": "2.0.9",
"@nativescript/schematics-executor": "0.0.2",
"@rigor789/resolve-package-path": "^1.0.5",
"axios": "^0.21.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/doctor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nativescript/doctor",
"version": "2.0.8",
"version": "2.0.9",
"description": "Library that helps identifying if the environment can be used for development of {N} apps.",
"main": "src/index.js",
"types": "./typings/nativescript-doctor.d.ts",
Expand Down
1 change: 1 addition & 0 deletions packages/doctor/src/android-tools-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
"android-30",
"android-31",
"android-32",
"android-33",
];

const isRuntimeVersionLessThan = (targetVersion: string) => {
Expand Down
9 changes: 6 additions & 3 deletions packages/doctor/test/android-tools-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ describe("androidToolsInfo", () => {
"30.0.0",
"31.0.0",
"32.0.0",
"33.0.0",
];
} else {
return [
Expand All @@ -65,6 +66,7 @@ describe("androidToolsInfo", () => {
"android-30",
"android-31",
"android-32",
"android-33",
];
}
},
Expand Down Expand Up @@ -100,7 +102,7 @@ describe("androidToolsInfo", () => {
const androidToolsInfo = getAndroidToolsInfo("8.2.0");
const toolsInfo = androidToolsInfo.getToolsInfo({ projectDir: "test" });

assert.equal(toolsInfo.compileSdkVersion, 32);
assert.equal(toolsInfo.compileSdkVersion, 33);
});
});

Expand Down Expand Up @@ -132,10 +134,11 @@ describe("androidToolsInfo", () => {
assertSupportedRange("8.1.0", min, max);
});

it("runtime 8.2.0 should support android-17 - android-32", () => {
it("runtime 8.2.0 should support android-17 - android-33", () => {
const min = 17;
const max = 32;
const max = 33;
assertSupportedRange("8.2.0", min, max);
assertSupportedRange("8.3.0", min, max);
});
});

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,10 @@
"resolved" "https://registry.npmjs.org/@kwsites/promise-deferred/-/promise-deferred-1.1.1.tgz"
"version" "1.1.1"

"@nativescript/[email protected].8":
"integrity" "sha512-/jVGBBBBY2BX1IwriDyXHNi0ZNAkSuzdDQuGY3nUl3BDLu5AM+FFg4qCG3D9IW664WLbA1KbJQd+HUSjRHM/ZQ=="
"resolved" "https://registry.npmjs.org/@nativescript/doctor/-/doctor-2.0.8.tgz"
"version" "2.0.8"
"@nativescript/[email protected].9":
"integrity" "sha512-/4Y3wkB5fQHr7oZVl15uQz1vwZPeL5dxVdts/djakJczIFKHozTL4k31rH1/82fExB5HvzzfJZhEvocwkS+/lw=="
"resolved" "https://registry.npmjs.org/@nativescript/doctor/-/doctor-2.0.9.tgz"
"version" "2.0.9"
dependencies:
"lodash" "4.17.21"
"osenv" "0.1.5"
Expand Down