Refactor OS detection for Debian and Ubuntu to use regex matching#19
Open
BiRo96 wants to merge 1 commit intoNayamAmarshe:mainfrom
Open
Refactor OS detection for Debian and Ubuntu to use regex matching#19BiRo96 wants to merge 1 commit intoNayamAmarshe:mainfrom
BiRo96 wants to merge 1 commit intoNayamAmarshe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my Linux Mint the following command gives the following result:
in this case the ubuntu or debian if statement is false since it's not "ubuntu" or "debian" but "ubuntu debian" all together...
so I modified the detection code to use regex, to find these to words in any kind of combination.
so it does in case of my Linux Mint