Skip to content

Added missing TransportMode field to accompany existing TransportSubmode#145

Closed
seime wants to merge 8 commits intoNeTEx-CEN:masterfrom
entur:validityparameters_transportmode_cen
Closed

Added missing TransportMode field to accompany existing TransportSubmode#145
seime wants to merge 8 commits intoNeTEx-CEN:masterfrom
entur:validityparameters_transportmode_cen

Conversation

@seime
Copy link
Contributor

@seime seime commented Jan 29, 2021

TransportMode and TransportSubmode usually come in pairs several places in NeTEx.
In parameter assignments/validityParameters it is missing, instead there is a VehicleMode.

This PR adds TransportMode to accompany TransportSubmode

The PR has been discussed with @nick-knowles that will verify that it aligns well with other parts of Netex.

@skinkie skinkie requested review from Aurige and skinkie July 14, 2021 08:56
@skinkie skinkie added the needs documentation update The NeTEx document needs to be updated label Jul 14, 2021
@skinkie
Copy link
Contributor

skinkie commented Jul 14, 2021

This requires a documentation update.

image

@syversenkr syversenkr mentioned this pull request Mar 8, 2022
Closed
@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Apr 13, 2022
@skinkie skinkie requested a review from ue71603 April 13, 2022 22:20
ue71603
ue71603 reviewed Apr 13, 2022
View reviewed changes
ue71603
ue71603 reviewed Apr 13, 2022
View reviewed changes
xsd/netex_part_3/part3_fares/netex_accessRightParameter_version.xsd Outdated
<xsd:documentation>Vehicel Modes to which ACCESS RIGHTs apply.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="TransportMode" type="AllVehicleModesOfTransportEnumeration" minOccurs="0">
Copy link
Contributor

@ue71603 ue71603 Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit unsure about this one: What is the difference between the TransportMode and the previous VehicleModes?
And what would the single TransportMode/TransportSubmode pair express in the context of the OrganisationValidityParametersGroup?

Copy link
Contributor

@ue71603 ue71603 May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christophe: The second pair is for TPEG compatibility.

Copy link
Contributor

@ue71603 ue71603 May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aurige I can't add a comment that this is for TPEG compatibility. Either you add it or we do it and afterwards think about it.

@skinkie
Copy link
Contributor

skinkie commented Apr 15, 2022

@ue71603 can you approve this one, typo is also fixed in my merge.

@skinkie skinkie requested a review from ue71603 April 15, 2022 20:06
@skinkie skinkie mentioned this pull request Apr 19, 2022
Closed
@ue71603
Copy link
Contributor

ue71603 commented Apr 20, 2022

@skinkie as we decided not to do #330 should we do this one? But then we are stuck with not answering #300

@skinkie
Copy link
Contributor

skinkie commented Apr 20, 2022

What is the reason VehicleModes is prefered of TransportModes @Aurige ?

@Aurige
Copy link
Contributor

Aurige commented Apr 20, 2022

you need to select one or the other, I just favour the original Transmodel over the TPEG compatibility one (own point of view here)

seime and others added 7 commits April 29, 2022 09:04
@seime
Changed charset encoding from latin1, latin2 to UTF-8 (NeTEx-CEN#352)
859208d
@seime
Removed some obsolete files (NeTEx-CEN#358)
879909a
@seime
Remove editor commercial (NeTEx-CEN#357)
67be14f 
* Removed comment about which editor made the change

* Removed comment about which editor was used
@seime
Separate huge changelog from README.md into CHANGELOG.md (NeTEx-CEN#356)
5a9657a
@seime
Formatting initial reformat (NeTEx-CEN#355)
f22a4f6 
* Added Spotless tool to verify and correct xsd/xml file formatting

* Attempt at making Travis validate

* Add more JVM memory, appears to speed up the formatting process

* Only require reformatting of files that have changed since 'master' branch

* Improved documentation

* More docs on formatting

* Fix command line option

* Replaced shall with must for character encoding

* Initial reformatting using Spotless - rules from Eclipse WTP project located in eclipsecodestyle/xml.prefs

* More reformatting after rebasing

* Updated copyright header year (just to trigger build)

* Set travis timeout to 6 hours. Must be reverted after first build

* Make jar plugin include all xsd files

* Bump spotless to latest version

* Run maven with debug trace

* Attempt at getting travis to run

* Disabled formatting checks in travis temporarily
@ue71603
remove netex_all_filters.xsd (NeTEx-CEN#364)
a52b010
@ue71603
redoing NeTEx-CEN#339 work (NeTEx-CEN#363)
97bc148
ue71603
ue71603 approved these changes May 19, 2022
View reviewed changes
xsd/netex_part_3/part3_fares/netex_accessRightParameter_version.xsd Outdated
<xsd:documentation>Vehicel Modes to which ACCESS RIGHTs apply.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="TransportMode" type="AllVehicleModesOfTransportEnumeration" minOccurs="0">
Copy link
Contributor

@ue71603 ue71603 May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christophe: The second pair is for TPEG compatibility.

xsd/netex_part_3/part3_fares/netex_accessRightParameter_version.xsd Outdated
<xsd:documentation>Vehicel Modes to which ACCESS RIGHTs apply.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="TransportMode" type="AllVehicleModesOfTransportEnumeration" minOccurs="0">
Copy link
Contributor

@ue71603 ue71603 May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aurige I can't add a comment that this is for TPEG compatibility. Either you add it or we do it and afterwards think about it.

@seime seime closed this May 24, 2022
@seime seime force-pushed the validityparameters_transportmode_cen branch from 1da1c6f to 97bc148 Compare May 24, 2022 12:45
@seime
Copy link
Contributor Author

seime commented May 24, 2022

Since PR was originally created, a new element TransportModes has arrived;

        <xsd:element name="TransportModes" type="AllModesListOfEnumerations" minOccurs="0">
          <xsd:annotation>
            <xsd:documentation>ANy mode to which Mode validitry parameters apply + v1.2.2</xsd:documentation>
          </xsd:annotation>
        </xsd:element>

This is of another enum again

@seime seime reopened this May 24, 2022
@nick-knowles
Copy link
Contributor

nick-knowles commented Apr 18, 2023

Added to UML
image

@ue71603 ue71603 mentioned this pull request Dec 19, 2023
Merged
@ue71603
Copy link
Contributor

ue71603 commented Dec 19, 2023

main part was already there. closed here and example and typo done here: #618

@ue71603 ue71603 closed this Dec 19, 2023
@trurlurl
Copy link
Collaborator

trurlurl commented Jul 4, 2024

Removing "needs documentation update" label since closed without having been merged.

@trurlurl trurlurl removed the needs documentation update The NeTEx document needs to be updated label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skinkie skinkie skinkie approved these changes

@ue71603 ue71603 ue71603 approved these changes

@Aurige Aurige Awaiting requested review from Aurige

Assignees

@nick-knowles nick-knowles

@Aurige Aurige

@syversenkr syversenkr

Labels

bug Technical mistake, inconsistency with the documentation, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@seime @skinkie @ue71603 @Aurige @nick-knowles @trurlurl @syversenkr