enhancement-TMCR-add ACCEPTED DRIVER PERMITs#408
Closed
nick-knowles wants to merge 14 commits intoNeTEx-CEN:masterfrom
Closed
enhancement-TMCR-add ACCEPTED DRIVER PERMITs#408nick-knowles wants to merge 14 commits intoNeTEx-CEN:masterfrom
nick-knowles wants to merge 14 commits intoNeTEx-CEN:masterfrom
Conversation
* Removed comment about which editor made the change * Removed comment about which editor was used
* Added Spotless tool to verify and correct xsd/xml file formatting * Attempt at making Travis validate * Add more JVM memory, appears to speed up the formatting process * Only require reformatting of files that have changed since 'master' branch * Improved documentation * More docs on formatting * Fix command line option * Replaced shall with must for character encoding * Initial reformatting using Spotless - rules from Eclipse WTP project located in eclipsecodestyle/xml.prefs * More reformatting after rebasing * Updated copyright header year (just to trigger build) * Set travis timeout to 6 hours. Must be reverted after first build * Make jar plugin include all xsd files * Bump spotless to latest version * Run maven with debug trace * Attempt at getting travis to run * Disabled formatting checks in travis temporarily
… ConditionSummaryStructure
ConditionSummaryChargingGroup not referenced from ConditionSummaryStructure
…ingCalculationGroup Fix annotation errors and align with definitions in NeTEx pt 3
Add ACCEPTED DRIVER PERMITS to VEHICEL TYpe
Contributor
|
@nick the PR should be one (or a few lines) but you accidentally collect a lot of changes (mainly presentation/indentation) that create hundreds of small changes... so it is not easy to identify the real change, and there are a lot of unnecessary ones. |
Contributor
Author
|
When using XML spy I usually hit the pretty print at the end to tidy up
the XML layout eliminate gratuitous CFetc Is this causing issues? It
isnt really viable not to?
…On Tue, 31 Jan 2023 at 07:48, Christophe Duquesne ***@***.***> wrote:
@nick <https://github.com/nick> the PR should be one (or a few lines) but
you accidentally collect a lot of changes (mainly presentation/indentation)
that create hundreds of small changes... so it is not easy to identify the
real change, and there are a lot of unnecessary ones.
—
Reply to this email directly, view it on GitHub
<#408 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN55S73QZTJJVECD3NITT3WVC7TVANCNFSM6AAAAAAULYQTYY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Yes, the pretty print is most likely the issue (you can also tune it in preferences) |
Contributor
|
Also, it's best for addition to start from "next" branch, not master. |
Merged
Contributor
|
@skinkie can this one be closed? |
Contributor
|
integrated into #612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ACCEPTED DRIVER PERMITS to SIMPLE VEHICLE TYpe