Prefix netex as namespace of DistributionGroupRef#449
Conversation
|
@ue71603 can you take a peak how to make the examples working? |
|
@skinkie I think the part iabout the DistributionGroupRef is not needed as DistributionGroupRef is a restriction of the GeneralGroupOfEntitiesRefStructure What do you think? |
|
I think we should have at least one example that actually is using a DistributionGroupRef. It is obviously that since we started fixing the constraints these issues popped up. |
|
The failed ones used it:
|
|
what do you think about the latest commit? |
|
...at least the DistributionGroupRef is fixed... |
…EN/NeTEx into fix_distributiongroupref
…EN/NeTEx into fix_distributiongroupref
examples/functions/fares/Netex_101.21_TfL_GeographicFares_UnitZone_MultipleProduct.xml
Outdated
Show resolved
Hide resolved
examples/functions/fares/Netex_101.21_TfL_GeographicFares_UnitZone_MultipleProduct.xml
Outdated
Show resolved
Hide resolved
examples/functions/fares/Netex_101.21_TfL_GeographicFares_UnitZone_MultipleProduct.xml
Outdated
Show resolved
Hide resolved
…EN/NeTEx into fix_distributiongroupref
…Zone_MultipleProduct.xml Co-authored-by: Stefan de Konink <stefan@konink.de>
| <Name>Visitor centres</Name> | ||
| <PaymentMethods>debitCard creditCard companyCheque cash</PaymentMethods> | ||
| <DistributionGroupRef version="any" ref="nr:Visitor_Centres"/> | ||
| <DistributionGroupRef version="any" ref="tfl:Visitor_Centres"/> |
There was a problem hiding this comment.
Why do you want the DistributionGroup to have the exact same Id as the DistributionChannel !!!?? That will not work
There was a problem hiding this comment.
it worked fined. There is no nr:Visitor_Centers that could be referenced. And the id are per class so it works as well. The id references the GeneralGroupOfEntities (and there is only tfl:Visitor_Centres):
<GeneralGroupOfEntities version="any" id="tfl:Visitor_Centres" nameOfMemberClass="AccessSpace"> <Name>List of visitor centres</Name> <members> <AccessSpaceRef version="1" ref="tfl:Piccadilly_Circus_Visitor_Centre"/> <AccessSpaceRef version="1" ref="tfl:Euston_Station_Visitor_Centre"/> <AccessSpaceRef version="1" ref="tfl:Victoria_Station_Visitor_Centre"/> <AccessSpaceRef version="1" ref="tfl:Heathrow_Terminal_123_Visitor_Centre"/> </members> </GeneralGroupOfEntities>
it does not reference to the DistributionChannel:
<DistributionChannel version="any" id="tfl:Visitor_Centres"> <Name>Visitor centres</Name> <PaymentMethods>debitCard creditCard companyCheque cash</PaymentMethods> <DistributionGroupRef version="any" ref="tfl:Visitor_Centres"/> </DistributionChannel>
There was a problem hiding this comment.
I'm lost here: in this example tfl:Visitor_Centres is the id of the DistributionChannel <DistributionChannel version="any" id="tfl:Visitor_Centres"> that has an element refering itself as a DistributionGroup ! I don't get the semantinc, neither the technical side of it !
There was a problem hiding this comment.
@Aurige This is no my example. I just made it working. That the DistributionChannel and the Group used the same id text I don't know. Who knows? @nick-knowles ?
There was a problem hiding this comment.
in fact it was ok with a different namespace, but changing the namespace to "tfl" create an inconsistency !
|
My fault, but: It was only ok, because no "version" was defined. With a version it no longer validated. And the other GroupofEntities was not in existance. So I used the one that was there. |
examples/functions/fares/Netex_101.21_TfL_GeographicFares_UnitZone_MultipleProduct.xml
Show resolved
Hide resolved
…Zone_MultipleProduct.xml
Fix #448