Skip to content

Revert new modes StopPlace_ abstract on stopPlacesInFrame_RelStructure#513

Merged
ue71603 merged 7 commits intomasterfrom
revert_stopplaces_abstract
Feb 19, 2024
Merged

Revert new modes StopPlace_ abstract on stopPlacesInFrame_RelStructure#513
ue71603 merged 7 commits intomasterfrom
revert_stopplaces_abstract

Conversation

@skinkie
Copy link
Contributor

@skinkie skinkie commented Sep 29, 2023

Fix #512

@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Sep 29, 2023
@skinkie skinkie self-assigned this Sep 29, 2023
@ue71603
Copy link
Contributor

ue71603 commented Nov 21, 2023

@skinkie seems not to work.

@ue71603 ue71603 added this to the netex_1.2 milestone Dec 1, 2023
@skinkie skinkie assigned ue71603 and unassigned skinkie Jan 17, 2024
@ue71603
Copy link
Contributor

ue71603 commented Jan 19, 2024

@skinkie it needs to be the StopPlace_ otherwise the substution e.g. for TaxiRank is not working.
image

So I would not do this one. Or does it cause problems elsewhere?

@ue71603
Copy link
Contributor

ue71603 commented Jan 24, 2024

Currently under stopPlaces
StopPlace and TaxiRank are possible. However, it would be more aligned with the rest to have
taxiRanks as a separate grouping within SiteFrame. Shall we adapt it.

@ue71603
Copy link
Contributor

ue71603 commented Jan 24, 2024

@Aurige @nick-knowles
Had to change this. stopPlaces now can no longer contain TaxiRank (and I think this is good, because we did this also for all other things. VehicleMeetingPoint never was allowed in stopPlaces so I changed the description.

@ue71603 ue71603 added change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. needs documentation update The NeTEx document needs to be updated labels Jan 24, 2024
@ue71603 ue71603 requested a review from trurlurl January 24, 2024 20:19
@ue71603 ue71603 removed their assignment Jan 24, 2024
trurlurl
trurlurl requested changes Jan 24, 2024
View reviewed changes
ue71603 and others added 2 commits January 25, 2024 01:12
@ue71603 @trurlurl
Update xsd/netex_part_1/part1_ifopt/netex_taxiPlace_version.xsd
db7237d 
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
@ue71603 @trurlurl
Update xsd/netex_part_1/part1_ifopt/netex_ifopt_stopPlace_version.xsd
2d18874 
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
@ue71603
Copy link
Contributor

ue71603 commented Jan 25, 2024

@skinkie no VehicleMeetingPoints have their own structure. So we are good, I think.

@skinkie
Copy link
Contributor Author

skinkie commented Jan 25, 2024

Then is the introduction of taxiRanks we want to do at master or at next? I would say this is a fix on master.

@ue71603
Copy link
Contributor

ue71603 commented Jan 25, 2024 via email

@ue71603 ue71603 merged commit f515961 into master Feb 19, 2024
@ue71603 ue71603 deleted the revert_stopplaces_abstract branch February 19, 2024 12:02
@trurlurl trurlurl added UML update needed Update UML physical model needed and removed needs documentation update The NeTEx document needs to be updated labels Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ue71603 ue71603 ue71603 approved these changes

@Aurige Aurige Aurige approved these changes

@trurlurl trurlurl trurlurl approved these changes

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

Assignees

@Aurige Aurige

Labels

bug Technical mistake, inconsistency with the documentation, etc. change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. UML update needed Update UML physical model needed

Projects

None yet

Milestone

netex_1.2

Development

Successfully merging this pull request may close these issues.

Too generic type for stop places in SiteFrame

4 participants

@skinkie @ue71603 @Aurige @trurlurl