Skip to content

rest from #123#622

Closed
ue71603 wants to merge 4 commits intomasterfrom
rest_from_123
Closed

rest from #123#622
ue71603 wants to merge 4 commits intomasterfrom
rest_from_123

Conversation

@ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 21, 2023

according to comment from Christophe
#123

@ue71603 ue71603 added change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. needs documentation update The NeTEx document needs to be updated labels Dec 21, 2023
@ue71603 ue71603 added this to the netex_1.2 milestone Dec 21, 2023
@ue71603 ue71603 mentioned this pull request Dec 21, 2023
Closed
@ue71603
Copy link
Contributor Author

ue71603 commented Dec 21, 2023

@Aurige Perhaps the restriction is too strict and we should forget about it.....
actualVehicleEquipments would only allow for Refs.
Pls advise.

@ue71603 ue71603 requested a review from nick-knowles December 21, 2023 14:52
@Aurige
Copy link
Contributor

Aurige commented Dec 21, 2023

@Aurige Perhaps the restriction is too strict and we should forget about it.....
actualVehicleEquipments would only allow for Refs.
Pls advise.

I'm personnaly Ok with both solutions, so if you think it is too strict we can forget it

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 22, 2023

I messed up also, I guess. but I feel we can also not do it.
@nick-knowles : Any strong feelings about just closing this one?

@ue71603
Copy link
Contributor Author

ue71603 commented Apr 10, 2024

Closing it

@ue71603 ue71603 closed this Apr 10, 2024
@trurlurl
Copy link
Collaborator

trurlurl commented Jun 20, 2024

Removing "needs documentation update" since closed without merging.

@trurlurl trurlurl removed the needs documentation update The NeTEx document needs to be updated label Jun 20, 2024
@skinkie skinkie deleted the rest_from_123 branch November 19, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skinkie skinkie skinkie left review comments

@Aurige Aurige Awaiting requested review from Aurige

@trurlurl trurlurl Awaiting requested review from trurlurl

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

Assignees

No one assigned

Labels

change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp.

Projects

None yet

Milestone

netex_1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ue71603 @Aurige @trurlurl @skinkie