Merged
Conversation
…_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Add extra enum values to bed ty[e
Add bus and train examples for deck plans. Fix various equipment issues. Revise DEckPlanassignment
Add deck plane xamples and update deck path
(1) Refactor Path Links and Navigation Paths as a generic PATH LINK stub in core . Place common enums as Reusable environment_support package. (2) Revise IFOPT pt1 SItePathLinks to extend generic PathLink (3) Also Add DECK PATH and DECK NAVIGATION PATHs to extend generic Path Link. Add new constraints to pub file. (4) Add Bus DEck Plan example (5) Add extensive train DECK PLAN example with train make up and boarding poistion akigmnet and Deck Navigation path example. ALso had to fix upo some existing example to pass validation PassengerCapacity
Contributor
|
Result discussion:
|
Contributor
|
Looking at commits, it looks that al lot of them are coming from master (and not next) like #579 which explains the PassengerCapacity issue that Nick faced (and that will have to be managed at some point in next anyway). |
Contributor
|
Is this a final review of the difference master/next to this PR? I guess a check with this one needs to be done: #615 |
Contributor
|
All the commits from #615 look to be inside this one: I don't know why we don't see it as the PR itself (as all the ones imported from master)... maybe @nick-knowles cherry picked them ? |
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…rsion.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Co-authored-by: Johan Wiklund <33256409+JohanEntur@users.noreply.github.com>
Contributor
This should be a case by case evaluation. This is really... odd. |
This was referenced Mar 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

(1) Refactor Path Links and Navigation Paths as a generic PATH LINK stub in core . Place common enums for paths and site environment as reusable netex_environment_support package.
(2) Revise IFOPT pt1 SItePathLinks to suptype generic PathLink add SItePathJunction
(3) Also Add DECK PATH and DECK NAVIGATION PATHs talso extending generic Path Link. Add new constraints to publication file. for enw elements
(4) Add Bus Deck Plan example with layour for double decker bus
(5) Add extensive train DECK PLAN example (a) with three cartriage types couchettes, (b) motro rail and buffet . (c) Include train make up and boarding poisition alignment and (d) Deck Navigation path example.
ALso had to fix up o some existing examples to pass validation checks esp PassengerCapacity