Skip to content

Comments

PrintColourValueType#852

Merged
ue71603 merged 3 commits intonextfrom
background_colour
Apr 19, 2025
Merged

PrintColourValueType#852
ue71603 merged 3 commits intonextfrom
background_colour

Conversation

@trurlurl
Copy link
Collaborator

The changes reflect my understanding that everything should be using print colours and that print colours are not limited to CMYK.

@trurlurl trurlurl added bug Technical mistake, inconsistency with the documentation, etc. needs documentation update The NeTEx document needs to be updated fix_now labels Apr 10, 2025
@trurlurl trurlurl added this to the netex_2.0 milestone Apr 10, 2025
@skinkie
Copy link
Contributor

skinkie commented Apr 10, 2025

Difficult, difficult... I think you want to have some sensible RGB value for onscreen production, but that will open another can of worms.

skinkie
skinkie previously approved these changes Apr 10, 2025
@trurlurl
Copy link
Collaborator Author

Difficult, difficult... I think you want to have some sensible RGB value for onscreen production, but that will open another can of worms.

@skinkie I think this has been taken care of, there already is a sibling ProductionStructure for onscreen colours.

@ue71603
Copy link
Contributor

ue71603 commented Apr 10, 2025

I have to disagree. PrintColourValueType is a string. It might e.g. be "mauve". If you don't know if its is CMYK or RGB or whatever itdoes not help.
ColourValueType is an RGB and is on purpose for direct representation on a screen (with the limitations). But this is machine processable. PrintColourValueType is not.

I agree that the definition of ColourValueType. better should read: RGB value of Colour.

Also the definition of PrintColourValueType is a mess (meaning completly useless)

From the examples it is clear that Colour is an RGB


					<Presentation>
						<Colour>00FFFF</Colour>
						<TextColour>00FFFF</TextColour>
					</Presentation>


							<Presentation>
								<ColourName>Pink</ColourName>
								<TextColourName>Black</TextColourName>
							</Presentation>


@trurlurl
Copy link
Collaborator Author

I've adapted the annotations a bit - does this clean the mess a bit? For all colours in PresentationStructure it is now clear that it has to be a RGB value.

@ue71603 ue71603 merged commit dab7346 into next Apr 19, 2025
1 check passed
@ue71603 ue71603 deleted the background_colour branch April 19, 2025 10:48
@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated fix_now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants