Conversation
ue71603
added
the
bug
|
I'm not well versed enough to understand if that's good or not (and time is limited before release). I wonder if that's something that could be delayed to cc @TuThoThai your opinion on this too? |
|
We certainly can delay it. The new XMLSpy always complaints about the XSD with two warnings. |
|
Thank you @ue71603 ; this will give us time for testing. We'll create a milestone and move it to there. |
Adding a comment for future deletion since the object is marked as deprecated from v2.0
|
Why do we have these constraints here ? Shouldn't they be in Publication as all the other ? \netex_framework\netex_responsibility\netex_typeOfValue_version.xsd \netex_part_2\part2_frames\netex_serviceFrame_version.xsd \netex_part_2\part2_frames\netex_serviceFrame_version.xsd This is not harming, but to be consistent and avoid any double in the future, it may be worth moving them all to NeTEx_Publication.xsd |
As per @Aurige comment, the following unicity constraints have been moved to NeTEx_publication.xsd: - KeyValuePair - PrivateCodeType - TypeOfValue_Unique SfUniqueLineId was deleted as already a comment in the file.
Commit 6778f14 addresses this comment |
| </xsd:unique> | ||
| <!-- =====TypeOfValue Key========================== --> | ||
| <xsd:key name="TypeOfValue_Key"> | ||
| <xsd:selector xpath="values/TypeOfValue"/> |
There was a problem hiding this comment.
| <xsd:selector xpath="values/TypeOfValue"/> | |
| <xsd:selector xpath=".//values/TypeOfValue"/> |
There was a problem hiding this comment.
Are we sure this works at this point? I don't know for sure, but shouldn't this be modeled like KeyValue?
There was a problem hiding this comment.
not sure what you mean here, KeyValue pairs don't have Id
| <xsd:field xpath="@version"/> | ||
| </xsd:key> | ||
| <!-- =====TypeOfValue unique========================== --> | ||
| <xsd:unique name="TypeOfValue_Unique"> |
There was a problem hiding this comment.
unique and key on the same attribute is redundant (key is enough)
Correction of the selector Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
5 participants
XMLSpy always had a problem.
This would fix it. But did I do it right? and then I would need to apply it to master too.