Rewrite shuttle computers for better code quality #5143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CI fail is genuine. |
MistakeNot4892
previously approved these changes
Sep 26, 2025
MistakeNot4892
added
awaiting author
out-of-phaze
force-pushed
the
codequality/shuttle-cleanup
branch
from
16354de to
46ba318
Compare
out-of-phaze
force-pushed
the
codequality/shuttle-cleanup
branch
from
46ba318 to
a05a079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites shuttle computers. Now instead of displaying a warning to the user on interaction if the evac controller is the wrong type, it throws a runtime error. This will probably mean it needs to be excluded from Create and Destroy testing and codex dump generation.
Makes them use
emag_act.Makes
authorizeda lazylist.Cleans up some really old decompiler artifacts like the use of
3.0, and renamesauth_needtoauths_needed.Eliminates one-line guard clauses because IIRC we don't like those.
Just overall cleans up the code.