Move brain-machine interfaces into a modpack#5210
Draft
out-of-phaze wants to merge 1 commit intoNebulaSS13:devfrom
Draft
Move brain-machine interfaces into a modpack#5210out-of-phaze wants to merge 1 commit intoNebulaSS13:devfrom
out-of-phaze wants to merge 1 commit intoNebulaSS13:devfrom
Conversation
out-of-phaze
added
the
work in progress
out-of-phaze
force-pushed
the
modpack/brain-interface
branch
2 times, most recently
from
78f5595 to
16fae9a
Compare
out-of-phaze
force-pushed
the
modpack/brain-interface
branch
from
16fae9a to
61252d9
Compare
out-of-phaze
added
awaiting author
out-of-phaze
force-pushed
the
modpack/brain-interface
branch
from
61252d9 to
e15528c
Compare
Member
Author
well fbps work at least
|
out-of-phaze
added
ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Moves MMIs and related content into a modpack. Cyborgs and flying cyborgs now require the modpack to be available.
Makes core code more brainmob-holder-agnostic when it comes to things like robot/AI construction.
AIs now take a brainmob rather than a brain organ in Initialize(), which changes basically nothing.
mmi_types_by_titleis nowprocessor_types_by_title.Adds a
drop_equipped_items()helper.Robotize()now exists on/mob/living./obj/item/projectile/changeWhy and what will this PR improve
I don't like these much, and I was really worried about them worming their way into core code as a dependency (like when posibrains/etc. were a subtype of them). This should ensure that can't happen again.
As a bonus: Some code that was broken (no longer accepted posibrains/circuitbrains) when digital MMIs were repathed to
brain/roboticshould now work again.