Skip to content

Conversation

@MistakeNot4892
Copy link
Contributor

Subset of the changes from #5262.

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Jan 15, 2026
@MistakeNot4892 MistakeNot4892 force-pushed the misc_polaris_changes branch 2 times, most recently from 78feca2 to eac951f Compare January 15, 2026 03:37
)
return spawnable_choices

/obj/random/hardsuit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/obj/random/hardsuit exists in code/game/objects/random/subtypes/suits.dm

)
return spawnable_choices

/obj/random/mug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in theory this could be better placed next to /obj/random/drinkingglass in misc.dm, or that could be moved here. not blocking though


/turf/floor/tiled/techfloor/cryo
initial_gas = list(/decl/material/gas/nitrogen = MOLES_CELLSTANDARD)
temperature = 73
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i sort of wonder if it might be better to write this as -200 CELSIUS, since 73 seems arbitrary whereas it's obvious when written with the celsius macro why it was chosen

lit = TRUE
atom_damage_type = BURN
if(REAGENT_VOLUME(reagents, /decl/material/liquid/fuel)) // the fuel explodes
var/explosive_power = round(REAGENT_VOLUME(reagents, /decl/material/liquid/fuel) / 5, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should maybe be generalised to a reagent var? not sure. because like, i remember doing this on lighthouse to allow phoron to burn in cigarettes, and it'd be nice if readding phoron required as few core edits as possible.

value = 1.5
exoplanet_rarity_gas = MAT_RARITY_EXOTIC
uid = "chem_antirads"
var/antirad_power = 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was to readd arithrazine in the baychems modpack, right? makes sense, i think toxins have a similar var for toxin strength. might need to do the same for oxygel so that we can adjust what level of CE_OXYGENATED it gives, we support 1-3 but it only ever gives 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is ready for review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants