-
Notifications
You must be signed in to change notification settings - Fork 247
Misc Polneb changes #5276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Misc Polneb changes #5276
Conversation
78feca2 to
eac951f
Compare
eac951f to
b8528ec
Compare
| ) | ||
| return spawnable_choices | ||
|
|
||
| /obj/random/hardsuit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/obj/random/hardsuit exists in code/game/objects/random/subtypes/suits.dm
| ) | ||
| return spawnable_choices | ||
|
|
||
| /obj/random/mug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in theory this could be better placed next to /obj/random/drinkingglass in misc.dm, or that could be moved here. not blocking though
|
|
||
| /turf/floor/tiled/techfloor/cryo | ||
| initial_gas = list(/decl/material/gas/nitrogen = MOLES_CELLSTANDARD) | ||
| temperature = 73 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i sort of wonder if it might be better to write this as -200 CELSIUS, since 73 seems arbitrary whereas it's obvious when written with the celsius macro why it was chosen
| lit = TRUE | ||
| atom_damage_type = BURN | ||
| if(REAGENT_VOLUME(reagents, /decl/material/liquid/fuel)) // the fuel explodes | ||
| var/explosive_power = round(REAGENT_VOLUME(reagents, /decl/material/liquid/fuel) / 5, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should maybe be generalised to a reagent var? not sure. because like, i remember doing this on lighthouse to allow phoron to burn in cigarettes, and it'd be nice if readding phoron required as few core edits as possible.
| value = 1.5 | ||
| exoplanet_rarity_gas = MAT_RARITY_EXOTIC | ||
| uid = "chem_antirads" | ||
| var/antirad_power = 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was to readd arithrazine in the baychems modpack, right? makes sense, i think toxins have a similar var for toxin strength. might need to do the same for oxygel so that we can adjust what level of CE_OXYGENATED it gives, we support 1-3 but it only ever gives 1.
Subset of the changes from #5262.