Fix issues with blood volume calculations #5278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Cleans up blood circulation and volume calculations to make more sense (at least to me, which means it makes sense to 1 person rather than 0).
Replaces a hardcoded
current_posture.pronecheck with a per-posture multiplier. Sitting now also gives a slight buff to circulating blood volume, a bit under half that of laying down.Fixes a bug with the effect of oxyloss on blood volume. It was accidentally scaling inversely with the square of species total health, so higher max health mobs had a dramatically diminished effect. This is unintended judging from older revisions; the intended math is now used, which means it should scale correctly for all species regardless of health. This is one of several issues making yinglets downstream extra-sensitive to oxyloss currently.
Why and what will this PR improve
Less hardcoded, easier to read, fixes a bug.
Authorship
Me. Also the Nuclear Phase dev for rewriting it downstream and giving me a reason to check out our own code and clean it up.