Auto turbo chargers. #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/resources/assets/monilabs/sounds/microverse.ogg
NegaNote
requested changes
Dec 18, 2025
Owner
NegaNote
left a comment
NegaNote
left a comment
There was a problem hiding this comment.
preliminary review of the stuff i immediately saw, seems to do its job properly with eu batteries in dev environment, will do more thorough review soon
also why isn't this in a branch????? don't pr from your fork's main branch bruh
| ftbteams_version = 2001.3.0 | ||
| jade_version = 11.6.3 | ||
| ae2_version=15.4.10-cosmolite.32 | ||
| ae2_version=15.4.10-cosmolite.26 |
Owner
There was a problem hiding this comment.
??? revert this change please i don't want cosmolite to be downgraded
| modImplementation("dev.architectury:architectury-forge:${architectury_version}") | ||
| jarJar(modImplementation("appeng:appliedenergistics2-forge:${ae2_version}")) | ||
| modImplementation("appeng:appliedenergistics2-forge:${ae2_version}") | ||
| jarJar("appeng:appliedenergistics2-forge:${ae2_version}") |
Owner
There was a problem hiding this comment.
unnecessary, the single line does both
Comment on lines
+174
to
+177
| if (elec != null) return elec.getCharge() >= elec.getMaxCharge(); | ||
|
|
||
| var fe = GTCapabilityHelper.getForgeEnergyItem(stack); | ||
| if (fe != null) return fe.getEnergyStored() >= fe.getMaxEnergyStored(); |
Owner
There was a problem hiding this comment.
please use curly braces for if-statements
| Component.translatable("tooltip.monilabs.hyperbolic_microverse_projector.description.2")); | ||
| }; | ||
|
|
||
| public static final MachineDefinition[] PARALLEL_HATCH = registerTieredParallelMachines("parallel_hatch", |
Owner
There was a problem hiding this comment.
Why remove the parallel hatches????
| "block.monilabs.iv_auto_charger_4x": "§9Insane Voltage§r 4x Auto Turbo Charger", | ||
| "block.monilabs.knowledge_transmission_array": "Knowledge Transmission Array", | ||
| "block.monilabs.luv_auto_charger_4x": "§dLudicrous Voltage§r 4x Auto Turbo Charger", | ||
| "block.monilabs.lv_auto_charger_4x": "§7Low Voltage§r 4x Auto Turbo Charger", |
Owner
There was a problem hiding this comment.
datagen is clearly not finished, there are no lang entries for zpm through uhv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds auto turbo chargers that allow input and output. Replaces those silly thermal machines.