Skip to content

fix: 타가족 랭킹 아이콘 추가 및 등수 겹침 오류 해결 #168

Merged
taekoong merged 19 commits intomainfrom
fe/feat/step-ranking
Aug 21, 2025
Merged

fix: 타가족 랭킹 아이콘 추가 및 등수 겹침 오류 해결 #168
taekoong merged 19 commits intomainfrom
fe/feat/step-ranking

Conversation

@taekoong
Copy link
Collaborator

@taekoong taekoong commented Aug 21, 2025

Summary by CodeRabbit

  • New Features
    • 건강 랭킹 라벨에 아이콘 추가
    • 사진 기록 목록 카드에서 프로필 아래 업로더 이름 배지 표시
  • UI
    • 랭킹 카드 크기·오프셋 및 현재 사용자 배지 위치 조정
    • 댓글 영역 상단 여백 추가 및 소소한 스타일 정리
  • Localization
    • ABDOMEN 표기를 “배”로 변경
  • Bug Fixes
    • 마음 로그 응답 파싱 안정성 개선
  • Chores
    • url_launcher 의존성 및 랭킹 아이콘 자산 추가

@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Walkthrough

여러 건강/사진 화면의 UI 레이아웃이 조정되고 라벨/아이콘이 추가되었습니다. 건강 상태 입력 화면에 번역 문구가 변경되고 디버그 로그가 추가되었습니다. MaumLogService에서 API 응답 타입 검증이 추가되었습니다. pubspec에 url_launcher 의존성과 SVG 자산이 등록되었습니다.

Changes

Cohort / File(s) Summary of Changes
Health UI 조정
frontend/ongi/lib/screens/health/cross_family_ranking_screen.dart, frontend/ongi/lib/screens/health/health_home_screen.dart
랭킹 카드 오프셋/폭 및 배지 위치 조정. 랭킹 라벨을 아이콘+텍스트 Row로 변경(SVG 자산 사용).
Health 상태 입력
frontend/ongi/lib/screens/health/health_status_input_screen.dart
ABDOMEN 한국어 번역을 “복부”→“배”로 변경. painArea 매핑 표현 단순화. 처리 과정 디버그 로그 추가. 경미한 UI/포매팅 정리.
Photo 화면 업데이트
frontend/ongi/lib/screens/photo/photo_date_screen.dart, frontend/ongi/lib/screens/photo/detail_record_screen.dart
maumLog 카드 좌측 컬럼에 프로필 이미지+업로더명 배지 추가 및 정렬/패딩 조정. 에러 메시지 구두점 변경(“: ”→“, ”). 기타 포매팅.
서비스 응답 검증
frontend/ongi/lib/services/maum_log_service.dart
getMaumLog에서 jsonDecode 결과가 Map인지 검사 후 파싱. 타입 불일치 시 예외 메시지에 런타임 타입 포함해 throw.
프로젝트 설정
frontend/ongi/pubspec.yaml
dependencies에 url_launcher: ^6.2.1 추가. assets에 assets/images/step_ranking_icon.svg 등록.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor UI as UI
  participant SVC as MaumLogService
  participant API as Backend API

  UI->>SVC: getMaumLog()
  SVC->>API: HTTP GET /maum-log
  API-->>SVC: response (status, body)
  alt status 200
    SVC->>SVC: jsonDecode(body) → responseBody
    alt responseBody is Map<String,dynamic>
      SVC->>SVC: MaumLogResponse.fromJson(responseBody)
      SVC-->>UI: MaumLogResponse
    else not a Map
      SVC-->>UI: throw Exception("Unexpected type: ${responseBody.runtimeType}")
    end
  else non-200
    SVC-->>UI: throw Exception(status/message)
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

깡총깡총, 커밋 위에 춤을 춰—
아이콘 빛, 랭킹 글이 반짝여.
“배”라 부르니 번역도 산뜻해,
로그는 토끼눈 같이 또렷해.
응답 타입 꼼꼼히 살피고,
새 길(launcher)로 뛰어가네—훕! 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4b0d437 and e58c8d1.

📒 Files selected for processing (2)
  • frontend/ongi/lib/screens/health/health_home_screen.dart (1 hunks)
  • frontend/ongi/lib/screens/health/health_status_input_screen.dart (7 hunks)
✅ Files skipped from review due to trivial changes (1)
  • frontend/ongi/lib/screens/health/health_status_input_screen.dart
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/ongi/lib/screens/health/health_home_screen.dart

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@taekoong taekoong merged commit 50a429c into main Aug 21, 2025
3 of 4 checks passed
Neibce added a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
* feat: 타가족 걸음수 랭킹 화면

* feat: 타가족 걸음수 랭킹 화면 연결

* feat: 타가족 걸음수 랭킹 화면 연결

* feat: 타가족 걸음수 랭킹 화면 연결

* feat: 도넛 차트 api 연결

* feat: 서비스 파일 pr

* feat: 운동 스트레칭 화면 구현

* fix: 스트레칭 관련 오류 수정

* feat: 운동 스트레칭 화면 구현

* fix: 마음 기록 추가 수정

* fix: 걸음수 랭킹 등수 크기 수정

* fix: 걸음수 랭킹 등수 아이콘 추가

---------

Co-authored-by: Junyoung Yang <y@jun0.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants