Skip to content

fix: 온도 히스토리 텍스트 형식 수정#169

Merged
surfwithus merged 1 commit intomainfrom
fix/degree-graph
Aug 21, 2025
Merged

fix: 온도 히스토리 텍스트 형식 수정#169
surfwithus merged 1 commit intomainfrom
fix/degree-graph

Conversation

@surfwithus
Copy link
Collaborator

@surfwithus surfwithus commented Aug 21, 2025

Summary by CodeRabbit

  • New Features

    • 홈 화면 히스토리 항목 문구가 상황에 맞게 동적으로 표시됩니다:
      • 사용자명이 ‘우리 가족’이면 ‘이’, 그 외에는 ‘ 님이’를 사용
      • 변화값이 0 이상이면 ‘상승’, 미만이면 ‘하강’으로 표기
      • 변화량 표기는 기존과 동일
  • Style

    • 표시 기능에 영향 없는 내부 포맷 조정

@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Walkthrough

UI 문자열 구성 로직이 변경되었습니다. 이력 항목 라벨이 사용자명과 기여값에 따라 조사(이/님이)와 동사(상승/하강)를 조건부로 선택합니다. 왼쪽 축 라벨 경계 필터 조건은 줄바꿈만 변경되었으며 동작은 동일합니다.

Changes

Cohort / File(s) Summary
홈 그래프 이력 라벨 로직
frontend/ongi/lib/screens/home/home_degree_graph.dart
- 이력 라벨: userName이 '우리 가족'이면 '이', 아니면 ' 님이' 사용
- 기여값(contributed) ≥ 0이면 '상승', 그렇지 않으면 '하강' 표시
- 이전 고정 문구에서 동적 문구로 변경
- 왼쪽 축 라벨 경계 조건은 포맷팅만 변경(동작 동일)

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as HomeDegreeGraph UI
  participant LB as LabelBuilder
  participant Data as HistoryItem

  UI->>Data: 각 HistoryItem 렌더링
  UI->>LB: buildLabel(userName, contributed, formattedChange)
  LB->>LB: particle = (userName == "우리 가족") ? "이" : " 님이"
  LB->>LB: verb = (contributed >= 0) ? "상승" : "하강"
  LB-->>UI: "${userName}${particle} ${formattedChange} ${verb} 시켰어요!"
  Note right of UI: 왼쪽 축 라벨 경계 조건은 변경 없음(포맷팅만)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

당근 깃발 흔들며 깡총깡총 뛰네,
“우리 가족”이면 “이”, 손님이면 “님이”라네.
숫자 오르면 상승! 내려가면 하강!
그래프에 춤추는 말, 토끼는 미소 팡.
작은 글자도 질서정연—포맷도 반짝! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b912dcb and 2a25d82.

📒 Files selected for processing (1)
  • frontend/ongi/lib/screens/home/home_degree_graph.dart (2 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surfwithus surfwithus merged commit 4f2b1a9 into main Aug 21, 2025
4 checks passed
@surfwithus surfwithus deleted the fix/degree-graph branch August 21, 2025 18:14
Neibce pushed a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
- userName이 "우리 가족"일 때 "님"을 붙이지 않도록 수정
- item.contributed가 음수인 경우 "하강시켰어요"로 표시
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant