Skip to content

fix: 등수 표현 , 오류 수정#173

Merged
taekoong merged 23 commits intomainfrom
fe/feat/step-ranking
Aug 21, 2025
Merged

fix: 등수 표현 , 오류 수정#173
taekoong merged 23 commits intomainfrom
fe/feat/step-ranking

Conversation

@taekoong
Copy link
Collaborator

@taekoong taekoong commented Aug 21, 2025

Summary by CodeRabbit

  • 스타일
    • 교차 가족 랭킹 화면의 카드 위치를 미세 조정했습니다. 현재 사용자와 다른 구성원의 가로 이동값을 줄여(오프셋 감소) 정렬감을 개선했습니다.
    • 현재 사용자 배지의 오버레이 위치를 조정해 메인 컨테이너와의 간격을 줄였고, 가독성과 시인성을 높였습니다.
    • 화면 전반의 요소 간 간격과 배치를 다듬어 시각적 일관성과 안정감을 향상했습니다.
    • 기능 동작, 데이터 처리에는 변경이 없습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

_cross_family_ranking_screen.dart_에서 랭킹 카드와 현재 사용자 배지의 Transform/Positioned 오프셋 값이 줄어들도록 조정되어, 수평 이동량과 배지 위치가 약간 안쪽으로 이동했습니다. 데이터 흐름, 상태 관리, 네트워킹, 예외 처리 등의 로직 변화는 없습니다.

Changes

Cohort / File(s) Change Summary
UI 레이아웃 조정
frontend/ongi/lib/screens/health/cross_family_ranking_screen.dart
Transform.translate의 수평 오프셋을 isCurrentUser 기준 30→20, 52→40으로 축소. 현재 사용자 배지 Positioned 좌표를 left -35→-25, top -40→-25로 조정. 순수 레이아웃 변경으로 로직 영향 없음.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

깡총, 살짝 옆으로—스윽 줄였지
배지는 가까이, 칭찬도 묘하게 빛나지 ✨
픽셀 두어 칸, 랭킹의 숨 고르기
바람처럼 가벼운 PR, 토끼는 박수 치기 🐇
오늘도 UI는 한 뼘 더 또렷해졌지


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a4867e7 and 9701473.

📒 Files selected for processing (1)
  • frontend/ongi/lib/screens/health/cross_family_ranking_screen.dart (2 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@taekoong taekoong merged commit 1589a29 into main Aug 21, 2025
2 of 4 checks passed
@Neibce Neibce deleted the fe/feat/step-ranking branch August 25, 2025 06:48
@Neibce Neibce restored the fe/feat/step-ranking branch August 25, 2025 06:48
Neibce added a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
* feat: 타가족 걸음수 랭킹 화면

* feat: 타가족 걸음수 랭킹 화면 연결

* feat: 타가족 걸음수 랭킹 화면 연결

* feat: 타가족 걸음수 랭킹 화면 연결

* feat: 도넛 차트 api 연결

* feat: 서비스 파일 pr

* feat: 운동 스트레칭 화면 구현

* fix: 스트레칭 관련 오류 수정

* feat: 운동 스트레칭 화면 구현

* fix: 마음 기록 추가 수정

* fix: 걸음수 랭킹 등수 크기 수정

* fix: 걸음수 랭킹 등수 아이콘 추가

* fix: 걸음수 표현

* fix: 등수 표현 , 오류 수정

---------

Co-authored-by: Junyoung Yang <y@jun0.dev>
@Neibce Neibce deleted the fe/feat/step-ranking branch August 28, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants