Skip to content

fix: 타 가족 걸음 수 화면 로고 변경 및 하단 순위 컨테이너 간격 조절#175

Merged
surfwithus merged 1 commit intomainfrom
fix/family-ranking
Aug 21, 2025
Merged

fix: 타 가족 걸음 수 화면 로고 변경 및 하단 순위 컨테이너 간격 조절#175
surfwithus merged 1 commit intomainfrom
fix/family-ranking

Conversation

@surfwithus
Copy link
Collaborator

@surfwithus surfwithus commented Aug 21, 2025

Summary by CodeRabbit

  • 신규 기능
    • 없음
  • 버그 수정
    • 가족 랭킹 화면에서 데이터 로딩 종료 후 상태가 간헐적으로 유지되던 문제를 개선하여 로딩 표시가 안정적으로 사라지도록 함.
  • 스타일
    • 상단 정보 버블과 하단 랭킹 박스 위치 조정.
    • 랭킹 아이템 여백, 폰트 크기/두께 미세 조정(이름 축소, 숫자 확대), 라벨 가독성 개선.
    • 내 순위 배지 위치 및 가독성 개선.
    • 전반적 간격(패딩/스페이싱) 미세 조정.
  • 잡무
    • 사용하지 않는 의존성 정리.

@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

_cross_family_ranking_screen.dart_에서 로딩 상태 처리에 finally 블록과 mounted 체크를 추가했고, 불필요한 import를 제거했으며, 여러 UI 위치/타이포그래피/패딩 값을 미세 조정했습니다. 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Summary
건강: 교차 가족 랭킹 화면 로직·레이아웃 조정
frontend/ongi/lib/screens/health/cross_family_ranking_screen.dart
_fetchFamilyRanks에 finally 추가 및 mounted 체크로 안전한 setState; 사용되지 않는 import 제거; 상단/하단 위젯 위치와 패딩·간격 미조정; 랭킹 아이템 오프셋/패딩/폰트 크기·굵기 일부 변경; 현재 사용자 배지 위치·텍스트 스타일 조정

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 사용자
  participant Screen as CrossFamilyRankingScreen
  participant API as RankingService

  User->>Screen: 화면 진입/새로고침
  activate Screen
  Note right of Screen: setState(_isLoading = true)
  Screen->>API: fetchFamilyRanks()
  activate API
  API-->>Screen: 결과 또는 오류
  deactivate API

  alt 성공
    Note right of Screen: setState(랭킹 데이터 반영)
  else 오류
    Note right of Screen: 오류 처리 (필요 시)
  end

  Note right of Screen: finally { if (mounted) setState(_isLoading = false) }
  deactivate Screen
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

토끼는 귀를 세우고 랭킹을 본다, 톡톡!
로딩 깃발은 올렸다가, finally에 살짝 접고 🏁
위젯은 한 칸 위, 배지는 살짝 왼쪽으로—슥.
숫자는 도톰, 이름은 조용—쓱.
버그야, mounted 확인하고 와라!
오늘도 깔끔히 뛰는 걸음수의 노래. 🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 407600e and b129314.

⛔ Files ignored due to path filters (1)
  • frontend/ongi/assets/images/cross_family_ranking_title_logo.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • frontend/ongi/lib/screens/health/cross_family_ranking_screen.dart (12 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surfwithus surfwithus merged commit 8ddd03f into main Aug 21, 2025
2 of 4 checks passed
@surfwithus surfwithus deleted the fix/family-ranking branch August 21, 2025 19:33
Neibce pushed a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant