Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughiOS 타겟을 14.0으로 상향하고, Podfile을 추가해 Flutter iOS 통합을 설정했습니다. Info.plist/Entitlements에 HealthKit 및 권한 키를 정리·추가했습니다. Flutter에 HealthDataService를 신설하고 앱 시작 및 건강 관련 화면에 통합하여 사용자 걸음 수를 읽고 서버 데이터와 병합·업데이트합니다. pubspec에 health 의존성을 추가했습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as 사용자
participant App as Flutter App
participant HDS as HealthDataService
participant Health as OS Health(HealthKit)
participant Server as API 서버
User->>App: 앱 실행
App->>HDS: setupHealthData()
HDS->>HDS: initialize()
HDS->>Health: 권한 보유 확인(hasPermissions)
alt 권한 미보유
HDS->>Health: 권한 요청(requestPermissions)
Health-->>HDS: 승인/거부
end
App-->>User: 초기화 완료 로그(성공/실패)
sequenceDiagram
autonumber
participant Screen as FamilyStepTrackerScreen
participant HDS as HealthDataService
participant Server as API 서버
Screen->>HDS: 초기화 및 권한 확인
alt 권한 허용됨
Screen->>HDS: getStepsForDate(오늘)
HDS-->>Screen: deviceSteps(오늘)
Screen->>Server: 오늘 deviceSteps 업로드
loop 30초 간격
Screen->>HDS: getStepsForDate(오늘)
HDS-->>Screen: 최신 deviceSteps
Screen->>Screen: 멤버 리스트 병합/정렬/총합 갱신
Screen->>Server: deviceSteps 업로드
end
else 권한 없음
Screen-->>Screen: 서버 데이터만 표시
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to cda34e0 in 1 minute and 57 seconds. Click for details.
- Reviewed
1089lines of code in11files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/ongi/lib/screens/health/family_step_tracker_screen.dart:272
- Draft comment:
Ensure that the 'firstOrNull' method is available (e.g. via package:collection) since it’s not a standard List method. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure the availability of a method, which is against the rules. It doesn't provide a specific suggestion or ask for a test to be written. It is more of a reminder or a prompt to double-check something, which is not allowed.
2. frontend/ongi/lib/services/health_data_service.dart:125
- Draft comment:
The getDetailedStepsData method currently returns an empty list; if detailed step data is needed, consider implementing it or add a comment that it's not supported. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. frontend/ongi/ios/Runner/Info.plist:36
- Draft comment:
NSAppTransportSecurity is configured to allow arbitrary loads. Ensure this relaxed setting is acceptable for production. - Reason this comment was not posted:
Comment was on unchanged code.
4. frontend/ongi/ios/Runner/Runner.entitlements:9
- Draft comment:
'com.apple.developer.healthkit.access' is set to an empty array. Confirm if this is intentional or if specific access types should be declared. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates several rules. It's asking for confirmation of intention ("Confirm if this is intentional..."). It's speculative since it's not stating a definite issue. Without deep knowledge of HealthKit requirements, we can't be certain if an empty array is problematic. The author likely configured this intentionally as part of enabling HealthKit. Maybe an empty HealthKit access array could cause runtime issues if specific permissions are required. The comment might be trying to prevent a potential bug. Even if specific permissions might be needed later, that would be caught during testing or runtime. This is a configuration choice that the author made deliberately, and we should trust their judgment without asking for confirmation. Delete this comment as it violates our rules by asking for confirmation of intention and making a speculative suggestion without clear evidence of an actual problem.
5. frontend/ongi/ios/Runner.xcodeproj/project.pbxproj:496
- Draft comment:
The DEVELOPMENT_TEAM ID has been updated (from a previous value to '55D5UTU9R9'). Verify that this change is intentional for your build configuration. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify if the change is intentional, which is against the rules. It doesn't provide a specific suggestion or point out a potential issue with the code itself. Therefore, it should be removed.
Workflow ID: wflow_mdxvb4Cf2X3I9LEe
You can customize 
| _totalSteps += difference; | ||
|
|
||
| // 현재 사용자의 걸음 수 업데이트 | ||
| final currentUserInfo = PrefsManager.getUserInfo(); |
There was a problem hiding this comment.
Consider refactoring async code: use await instead of chaining .then() for PrefsManager.getUserInfo() for clearer state updates.
This was referenced Aug 28, 2025
Neibce
pushed a commit
to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10
that referenced
this pull request
Aug 28, 2025
* feat: health 라이브러리 연결 * fix: 권한 요청 위치 변경 및 UI 수정 * fix: 권한 오작동 해결 * feat: 건강 기록 메인 화면에서 총 걸음 수가 아닌 유저 걸음 수로 표시되게 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Integrate Health library for iOS, update deployment target, and enhance UI to display Health data.
MinimumOSVersionto14.0inAppFrameworkInfo.plistandproject.pbxproj.PodfileandPodfile.lockfor CocoaPods dependencies, includinghealthlibrary.Runner.entitlementsto include HealthKit permissions.HealthDataServiceinhealth_data_service.dartfor managing Health data access and permissions.main.dartand handle permissions.FamilyStepTrackerScreento display and update step data using Health data.HealthHomeScreento fetch and display today's steps using Health data.This description was created by
for cda34e0. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit