Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough로그인/회원가입 준비 화면의 내비게이션 흐름에 튜토리얼 화면을 삽입했습니다. 새 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant ReadyScreen as Login/Signup ReadyScreen
participant Tutorial as TutorialScreen
participant SP as SharedPreferences
participant Main as BottomNavScreen
User->>ReadyScreen: 완료(로그인/회원가입)
Note right of ReadyScreen: async 내비게이션 흐름
ReadyScreen->>Tutorial: showIfNeeded(imageAssets)
Tutorial->>SP: 체크: 튜토리얼 노출 여부 키(_TutorialFlagKey)
alt 최초 노출 아님
SP-->>Tutorial: seen = true
Tutorial-->>ReadyScreen: false (표시 안 함)
else 최초 노출
SP-->>Tutorial: seen = false
Tutorial-->>ReadyScreen: push fullscreenDialog
rect rgba(200, 230, 255, 0.3)
Tutorial->>Tutorial: PageView 표시, 프리로딩, 스킵/다음/시작하기
end
Tutorial->>SP: seen = true 저장
Tutorial-->>ReadyScreen: true (표시 완료)
end
ReadyScreen->>Main: pushAndRemoveUntil (스택 정리)
sequenceDiagram
participant Widget as ReadyScreen State
Note right of Widget: mounted 체크
Widget->>Widget: if (!mounted) return
Widget->>Widget: await Navigator.push(...TutorialScreen)
Widget->>Widget: if (!mounted) return
Widget->>Navigator: pushAndRemoveUntil(BottomNavScreen)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 87cc522 in 53 seconds. Click for details.
- Reviewed
283lines of code in4files - Skipped
10files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/ongi/lib/screens/login/login_ready_screen.dart:23
- Draft comment:
Timer async callback: Using an async callback with Timer works, but consider using Future.delayed for improved clarity in asynchronous delays. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. frontend/ongi/lib/screens/signup/ready_screen.dart:50
- Draft comment:
Navigation logic duplication: Both login and signup screens use nearly identical logic to show the tutorial. Consider refactoring this code into a common method if the behavior is intended to be consistent. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. frontend/ongi/lib/screens/tutorial_screen.dart:45
- Draft comment:
Image preloading: The loop preloading images runs sequentially. Consider using Future.wait to load images concurrently for improved performance. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. frontend/ongi/lib/screens/tutorial_screen.dart:85
- Draft comment:
Skip button rendering: Using 'isLast ? null : Icons.skip_next_rounded' results in a null icon on the last page. Consider conditionally rendering the entire skip widget for clarity and accessibility. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. frontend/ongi/lib/screens/tutorial_screen.dart:14
- Draft comment:
Unused static method: The static method showIfNeeded (and the associated Tutorial flag) isn’t used in the current flow. If the tutorial is meant to be shown every time (as the comments indicate), consider removing or repurposing this method to avoid confusion. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. frontend/ongi/pubspec.yaml:76
- Draft comment:
Asset configuration: The tutorial asset folder is added. Ensure that the 'assets/images/tutorial/' folder exists and contains the expected images to avoid runtime asset loading issues. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_ftc2NTlTJaWXcP6V
You can customize 
Merged
Neibce
pushed a commit
to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10
that referenced
this pull request
Aug 28, 2025
* feat: tutorial 추가 * fix: 버튼 비활성화 해결
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds a tutorial screen to
LoginReadyScreenandReadyScreen, implemented intutorial_screen.dart, with image assets listed inpubspec.yaml.LoginReadyScreenandReadyScreenbefore navigating toBottomNavScreen.assets/images/tutorial/.TutorialScreenintutorial_screen.dartwith page navigation and skip functionality.SharedPreferencesto track if the tutorial has been seen.assets/images/tutorial/topubspec.yaml.This description was created by
for 87cc522. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit