Skip to content

feat: light background 및 color 추가 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surfwithus merged 1 commit into from
Jul 16, 2025
Merged

feat: light background 및 color 추가 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/ongi/lib/core/app_colors.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ import 'package:flutter/material.dart';
class AppColors {
static const ongiOrange = Color(0xFFFD6C01);
static const ongiBlue = Color(0xFFBFECFF);
static const ongiLigntgrey = Color(0xFFF7F7F7);
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

타이포 및 네이밍 컨벤션 불일치

ongiLigntgrey 는 Light 의 오타이며, 기존 패턴(카멜-케이스)과도 맞지 않습니다. 추후 사용 시 혼동을 유발하니 즉시 수정하는 편이 좋습니다.

-  static const ongiLigntgrey = Color(0xFFF7F7F7);
+  static const ongiLightGrey = Color(0xFFF7F7F7);

수정 후, 해당 상수를 참조하는 모든 위치(특히 AppLightBackground)도 함께 업데이트하세요.

🏁 Script executed:

#!/bin/bash
# 오타 수정 전후 상수 및 관련 사용 위치 검색
rg "ongiLigntgrey" -n .
rg "ongiLightGrey" -n .
rg "AppLightBackground" -n .

Length of output: 484

Typo 및 네이밍 컨벤션 수정 필요

ongiLigntgrey는 Light의 철자 오류이며, 카멜케이스 패턴(ongiLightGrey)에도 맞지 않습니다. 아래 파일들을 함께 고쳐주세요.

• frontend/ongi/lib/core/app_colors.dart (6행)

-  static const ongiLigntgrey = Color(0xFFF7F7F7);
+  static const ongiLightGrey  = Color(0xFFF7F7F7);

• frontend/ongi/lib/core/app_light_background.dart (13행)

-          color: AppColors.ongiLigntgrey,
+          color: AppColors.ongiLightGrey,

위 두 군데를 수정한 뒤, 관련 레퍼런스가 없는지 한 번 더 확인 부탁드립니다.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
static const ongiLigntgrey = Color(0xFFF7F7F7);
// File: frontend/ongi/lib/core/app_colors.dart
static const ongiLightGrey = Color(0xFFF7F7F7);
Suggested change
static const ongiLigntgrey = Color(0xFFF7F7F7);
// File: frontend/ongi/lib/core/app_light_background.dart
color: AppColors.ongiLightGrey,
🤖 Prompt for AI Agents 
In frontend/ongi/lib/core/app_colors.dart at line 6 and
frontend/ongi/lib/core/app_light_background.dart at line 13, fix the typo in the
color name from "ongiLigntgrey" to "ongiLightGrey" following camelCase
convention. After renaming, search the entire codebase for any references to the
old name and update them to the corrected name to ensure consistency and prevent
errors.

}
31 changes: 31 additions & 0 deletions frontend/ongi/lib/core/app_light_background.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import 'package:flutter/material.dart';
import 'package:ongi/core/app_colors.dart';

class AppLightBackground extends StatelessWidget {
final Widget child;
const AppLightBackground({super.key, required this.child});

@override
Widget build(BuildContext context) {
return Stack(
children: [
Container(
color: AppColors.ongiLigntgrey,
),
Positioned(
right: -140,
top: -160,
child: Opacity(
opacity: 0.3,
child: Image.asset(
'assets/images/logo.png',
width: 350,
fit: BoxFit.contain,
),
),
),
Positioned.fill(child: child),
],
);
}
}
Empty file removed frontend/ongi/lib/screens/login_screen.dart
View file
Open in desktop
Empty file.
Loading