Skip to content

fix: 오류수정#97

Merged
taekoong merged 24 commits intomainfrom
fe/connecting
Aug 9, 2025
Merged

fix: 오류수정#97
taekoong merged 24 commits intomainfrom
fe/connecting

Conversation

@taekoong
Copy link
Collaborator

@taekoong taekoong commented Aug 9, 2025

Summary by CodeRabbit

  • 버그 수정
    • 온도 데이터 및 기여도 데이터를 불러올 때 인증 토큰이 올바르게 전달되어 인증이 강화되었습니다.
    • 기여도 내역 표시 시 날짜 포맷이 일관되고 안전하게 표시됩니다.
    • 온도 및 기여도 데이터 처리 시 데이터 변환 및 예외 처리가 개선되었습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 9, 2025

Walkthrough

이번 변경에서는 온도 서비스의 API 호출 시 인증을 위한 액세스 토큰을 선호도에서 가져와 전달하도록 수정되었습니다. 또한, 기여 데이터의 JSON 응답을 명시적으로 객체로 변환하고, UI에서 타입 안정성과 널 처리 강화를 위해 데이터 바인딩 방식을 개선했습니다. 일부 불필요한 import도 정리되었습니다.

Changes

Cohort / File(s) Change Summary
홈 그래프 화면 및 데이터 바인딩 개선
frontend/ongi/lib/screens/home/home_degree_graph.dart
액세스 토큰을 선호도에서 가져와 API 호출 시 전달하도록 변경. 기여 데이터 JSON을 객체로 명시적 변환. 날짜 바인딩을 객체 프로퍼티로 변경하여 타입 안정성 및 널 처리 강화.
도넛 캡슐 화면 토큰 전달
frontend/ongi/lib/screens/home/home_donutCapsule.dart
불필요한 home_degree_graph.dart import 제거. 온도 데이터 조회 시 액세스 토큰을 추가 인자로 전달하도록 수정.
온도 서비스 응답 파싱 단순화
frontend/ongi/lib/services/temperature_service.dart
예상 키 미존재 시 전체 객체 반환 로직 제거, 지정된 키의 리스트 또는 빈 리스트만 반환하도록 파싱 로직 단순화.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant PrefsManager
    participant TemperatureService
    participant API

    UI->>PrefsManager: 액세스 토큰 요청
    PrefsManager-->>UI: 액세스 토큰 반환
    UI->>TemperatureService: fetchFamilyTemperatureDaily(토큰)
    TemperatureService->>API: API 요청(토큰 포함)
    API-->>TemperatureService: dailyTemperatures JSON 응답
    TemperatureService-->>UI: dailyTemperatures 리스트 반환

    UI->>TemperatureService: fetchFamilyTemperatureContributions(토큰)
    TemperatureService->>API: API 요청(토큰 포함)
    API-->>TemperatureService: contributions JSON 응답
    TemperatureService-->>UI: Contribution 객체 리스트 반환
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰
토큰을 챙겨 API로,
데이터는 객체로 변신하고,
날짜도 안전하게 보여주네.
import도 깔끔히 정리했지!
오늘도 토끼는 기쁘게,
코드 한 줄에 춤을 춘다.
🌱

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 7de0b58 and b1fa2b5.

📒 Files selected for processing (2)
  • frontend/ongi/lib/screens/home/home_degree_graph.dart (2 hunks)
  • frontend/ongi/lib/services/temperature_service.dart (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • frontend/ongi/lib/services/temperature_service.dart
  • frontend/ongi/lib/screens/home/home_degree_graph.dart

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@taekoong taekoong merged commit cab0d8d into main Aug 9, 2025
3 of 4 checks passed
@taekoong taekoong deleted the fe/connecting branch August 10, 2025 11:26
Neibce pushed a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
* feat: 온도그래프 화면으로 전환

* feat: 온도그래프 화면으로 전환

* feat: 온도그래프 화면으로 전환

* feat: 온도그래프 화면으로 전환

* feat: 온도그래프 화면으로 전환

* feat: 온도그래프 화면 구현

* feat: 온도그래프 화면 구현

* feat: 온도그래프 화면 구현

* feat: 온도그래프 화면 구현

* feat: 온도그래프 화면 구현

* feat: 마이페이지 및 온도지수 api연결

* feat: 마이페이지 api 연결

* feat: 마이페이지 api 연결

* feat: 가족기여도 api 연결

* feat: dkdkkkkkk

* feat: 서비스 업로드

* feat: 서비스 업로드

* feat: 서비스 업로드

* feat: 서비스 업로드
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant