fix/cleanup ci #103

Neiland85 · 2025-12-11T04:47:39Z

chore: ignore VSCode workspace file
cleanup: remove duplicated CI workflows and stabilize pipeline
security: mark public host bindings as intentional (#nosec B104)
refactor: config model now ignores extra fields + cleanup CI workflows
ci: temporarily disable Railway deploy (installer broken upstream)
chore: finalize cleanup before switching to OpenAI dossier work

…-Toolkit into fix/cleanup-ci

config.py

@@ -0,0 +1,22 @@
+from pydantic import field_validator


config.py

+    def settings_customise_sources(
+        cls, settings_cls, init_settings, env_settings, dotenv_settings, file_secret_settings
+    ):


Copilot

Pull request overview

This PR performs a comprehensive cleanup of the CI/CD pipeline, focusing on stabilizing workflows, improving configuration management, and preparing for Railway deployment. The changes standardize workflow naming conventions (using dashes instead of en-dashes), introduce a multi-stage Docker build for better security and reproducibility, and configure the application settings to ignore extra fields for more robust environment handling.

Key Changes:

Consolidation and cleanup of GitHub Actions workflows with standardized naming and Railway deployment strategies
Multi-stage Docker build implementation with Python 3.11, non-root user, and wheel-based dependency installation
Configuration model refactored to ignore extra fields and handle test environments separately

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`.github/workflows/ci.yml`	New consolidated quality checks workflow running linters, security scans, and tests across Python 3.11 and 3.12
`.github/workflows/deploy.yml`	Updated deployment workflow with Railway CLI fallback to API-based deployment, GHCR image push
`.github/workflows/test.yml`	Workflow name standardized from en-dash to hyphen
`.github/workflows/security.yml`	Workflow name standardized from en-dash to hyphen
`deploy_v2.yml`	New Railway deployment workflow using API-only approach (appears to be a duplicate/alternative)
`Dockerfile`	Refactored to multi-stage build with Python 3.11, non-root user, wheel-based installs for security and reproducibility
`.python-version`	Python version pinned to 3.11.8 for consistency
`app/config.py`	Added BaseAppSettings with extra fields ignored, new telemetry-related config fields
`config.py`	Configuration snippet showing pytest-aware settings customization
`app/telemetry.py`	New telemetry module with startup/shutdown event handlers and request metrics logging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-11T04:53:45Z

app/telemetry.py

+    @app.on_event("startup")
+    async def startup_telemetry():
+        logger.info("📊 Telemetry initialized successfully")
+        logger.info(f"📍 Application: {app.title} v{app.version}")
+
+    # Add shutdown event for cleanup
+    @app.on_event("shutdown")
+    async def shutdown_telemetry():
+        logger.info("📊 Telemetry shutdown complete")


The workflow file uses on_event decorators which are deprecated in FastAPI 0.109.1+. Since the project uses FastAPI 0.116.1 (per requirements.txt), this code should be refactored to use the modern lifespan context manager pattern instead. The current implementation may not work correctly or could be removed in future FastAPI versions.

Copilot · 2025-12-11T04:53:46Z

.github/workflows/deploy.yml

+
+    env:
+      IMAGE_NAME: ghcr.io/${{ github.repository_owner }}/neurobank:${{ github.sha }}
+      SERVICE_ID: "REPLACE_ME"     # <- luego pones el tuyo


The placeholder SERVICE_ID value "REPLACE_ME" will cause Railway deployments to fail. This should either be replaced with the actual service ID or configured as a GitHub secret and referenced via the secrets context.

Suggested change

SERVICE_ID: "REPLACE_ME" # <- luego pones el tuyo

SERVICE_ID: ${{ secrets.RAILWAY_SERVICE_ID }}

Copilot · 2025-12-11T04:53:46Z

.github/workflows/deploy.yml

+      - name: Trigger Railway deployment via API (fallback)
+        if: steps.cli_install.outputs.cli == 'false'
+        env:
+          RAILWAY_TOKEN: ${{ secrets.RAILWAY_TOKEN }}
+        run: |
+          echo "⚠️ CLI unavailable → Using API fallback mode."
+          echo "➜ Deploying image: $IMAGE_NAME"
+          
+          curl -X POST "$RAILWAY_API" \
+            -H "Content-Type: application/json" \
+            -H "Authorization: Bearer $RAILWAY_TOKEN" \
+            -d "{
+              \"query\": \"mutation { deployService(input: { serviceId: \\\"$SERVICE_ID\\\", image: \\\"$IMAGE_NAME\\\" }) { id } }\"
+            }"


The API fallback deployment logic only triggers when CLI installation fails (cli == 'false'), but not when the CLI deployment itself fails. Since the CLI deployment step has continue-on-error: true, a failed deployment won't trigger the API fallback. Consider changing the condition on line 71 to also check if the CLI deployment succeeded, or always run the API deployment as a backup.

Copilot · 2025-12-11T04:53:46Z

app/config.py

+    cors_origins: list[str] = Field(default_factory=list)
+


The field cors_origins is defined twice: once in the base class BaseAppSettings (line 14) and again in the Settings class (line 45 in the full file). This duplication will cause the child class definition to override the parent, potentially leading to confusion. Remove one of the definitions to avoid ambiguity.

Suggested change

cors_origins: list[str] = Field(default_factory=list)

Copilot · 2025-12-11T04:53:47Z

config.py

+from pydantic import field_validator
+
+class Settings(BaseSettings): # type: ignore
+    model_config = SettingsConfigDict( # type: ignore
+        env_file=".env",
+        extra="ignore"
+    )


Missing required imports for this configuration module. The code references BaseSettings and SettingsConfigDict which are not imported. Add the following imports:

from pydantic_settings import BaseSettings, SettingsConfigDict

Copilot · 2025-12-11T04:53:47Z

deploy_v2.yml

+        env:
+          RAILWAY_TOKEN: ${{ secrets.RAILWAY_TOKEN }}
+        run: |
+          SERVICE_ID="TU_SERVICE_ID"


The SERVICE_ID is set to a placeholder value "TU_SERVICE_ID" which will cause the Railway deployment to fail. This should either be replaced with the actual service ID or configured as a GitHub secret and referenced via secrets context.

Suggested change

SERVICE_ID="TU_SERVICE_ID"

SERVICE_ID="${{ secrets.RAILWAY_SERVICE_ID }}"

Copilot · 2025-12-11T04:53:47Z

config.py

+    def settings_customise_sources(
+        cls, settings_cls, init_settings, env_settings, dotenv_settings, file_secret_settings
+    ):


Settings.settings_customise_sources returns tuple of size 2 and tuple of size 4.

Copilot · 2025-12-11T04:53:48Z

config.py

+from pydantic import field_validator
+


Import of 'field_validator' is not used.

Suggested change

from pydantic import field_validator

Neiland85 · 2025-12-11T05:02:30Z

Merge Summary: Cleanup and Stabilization of CI/CD Pipeline

This pull request introduces a complete cleanup and stabilization of the CI/CD workflows across the repository.
It consolidates duplicated configurations, fixes inconsistencies, improves environment handling, and prepares the project for future deployment stages.

Key improvements included in this merge:

Standardized and cleaned all GitHub Actions workflows

Removed deprecated or duplicated CI files

Ensured configuration models ignore extra environment fields safely

Improved security posture by marking public host bindings as intentional (#nosec B104)

Temporarily disabled Railway deployment while the upstream installer remains broken

Added formatting consistency (Black + isort)

Introduced telemetry initialization and improved internal tooling

Finalized all CI-related cleanup before shifting focus to the OpenAI dossier work

All checks have passed (linting, quality checks, security scans, test suite),
and the branch is now stable and aligned with the main development workflow.

This merge strengthens the repository’s reliability, security, and maintainability moving forward.

Neiland85 added 7 commits December 11, 2025 02:45

chore: ignore VSCode workspace file

7833fed

cleanup: remove duplicated CI workflows and stabilize pipeline

3ba566d

security: mark public host bindings as intentional (#nosec B104)

f71817d

Merge branch 'main' of https://github.com/Neiland85/NeuroBank-FastAPI…

eca0e02

…-Toolkit into fix/cleanup-ci

refactor: config model now ignores extra fields + cleanup CI workflows

e1f8fac

ci: temporarily disable Railway deploy (installer broken upstream)

fd8082a

chore: finalize cleanup before switching to OpenAI dossier work

7c00f34

Copilot AI review requested due to automatic review settings December 11, 2025 04:47

Copilot started reviewing on behalf of Neiland85 December 11, 2025 04:48 View session

github-advanced-security bot found potential problems Dec 11, 2025

View reviewed changes

Copilot AI reviewed Dec 11, 2025

View reviewed changes

style: apply black and isort formatting

90a721e

Neiland85 merged commit bab28c7 into main Dec 11, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix/cleanup ci #103

fix/cleanup ci #103

Uh oh!

Neiland85 commented Dec 11, 2025

Uh oh!

Check notice

Check notice

Copilot AI left a comment

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Copilot AI Dec 11, 2025

Uh oh!

Neiland85 commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	SERVICE_ID: "REPLACE_ME" # <- luego pones el tuyo
	SERVICE_ID: ${{ secrets.RAILWAY_SERVICE_ID }}

	SERVICE_ID="TU_SERVICE_ID"
	SERVICE_ID="${{ secrets.RAILWAY_SERVICE_ID }}"

fix/cleanup ci #103

fix/cleanup ci #103

Uh oh!

Conversation

Neiland85 commented Dec 11, 2025

Uh oh!

Check notice

Check notice

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Neiland85 commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants