-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/cleanup ci #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cleanup ci #106
Changes from all commits
7833fed
3ba566d
f71817d
eca0e02
e1f8fac
fd8082a
7c00f34
90a721e
695bf0c
ab35196
c66ece7
cfafe3e
8c5f63a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -20,6 +20,9 @@ jobs: | |||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| - name: Login to GHCR | ||||||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||||||
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io \ | ||||||||||||||||||||||||||||||
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io \ | ||||||||||||||||||||||||||||||
| -u "${{ github.actor }}" --password-stdin | ||||||||||||||||||||||||||||||
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||||||||||||||||||||||||||||||
|
Comment on lines
+23
to
26
|
||||||||||||||||||||||||||||||
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io \ | |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io \ | |
| -u "${{ github.actor }}" --password-stdin | |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | |
| if [ -n "${{ secrets.GHCR_PAT }}" ]; then | |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin | |
| else | |
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin | |
| fi |
Copilot
AI
Dec 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step name has been changed from "Login to GHCR" to "Log in to GHCR" but the implementation has critical syntax errors. The original working implementation on line 26 should be preserved. For GitHub Container Registry authentication, GITHUB_TOKEN (which is automatically provided by GitHub Actions) is typically sufficient and is the recommended approach unless specific GHCR_PAT permissions are required.
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io \ | |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io \ | |
| -u "${{ github.actor }}" --password-stdin | |
| echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | |
| echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker login command has a syntax error. Lines 23-24 are incomplete commands that are missing proper continuation. The first line has an echo statement with a backslash but no actual docker login command, and the second line echoes a different secret but also doesn't complete properly. This will cause the workflow to fail during execution.
The correct approach is to use a single docker login command with one authentication token. You should either use GITHUB_TOKEN or GHCR_PAT, not both simultaneously. Line 26 shows the correct pattern.