Skip to content

fix: corregir comando docker login en deploy workflow #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neiland85 merged 1 commit into from
Dec 13, 2025
Merged

fix: corregir comando docker login en deploy workflow #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ jobs:

- name: Login to GHCR
run: |
echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io \
echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io \
-u "${{ github.actor }}" --password-stdin
echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin
echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable ${{ github.actor }} should be quoted for consistency and to prevent potential issues with special characters in usernames. This line uses an unquoted variable while line 23 properly quotes it as "${{ github.actor }}". Inconsistent quoting can lead to unexpected behavior in shell scripts.

Suggested change
echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having two different authentication secrets (GITHUB_TOKEN and GHCR_PAT) for the same purpose creates unnecessary complexity and potential confusion. Since the workflow already has the standard GITHUB_TOKEN configured with proper permissions (packages: write on line 12), the GHCR_PAT secret appears to be redundant. Consider using only one authentication method to simplify maintenance and reduce the risk of misconfiguration.

Suggested change
echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin

Copilot uses AI. Check for mistakes.

Comment on lines 24 to 25
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two docker login commands executing sequentially, which is redundant. The second login (line 24) will overwrite the authentication from the first login (line 23). Only one docker login command should be used.

Additionally, line 24 has an inconsistency: the variable ${{ github.actor }} is not quoted, unlike line 23 where it's properly quoted as "${{ github.actor }}". This could potentially cause issues if the username contains special characters.

Recommend keeping only one of these login commands, preferably using GITHUB_TOKEN since it's the standard authentication method for GitHub Container Registry in GitHub Actions.

Suggested change
echo "${{ secrets.GHCR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin

Copilot uses AI. Check for mistakes.
- name: Build Docker image
Expand Down