Fix/ci all checks #115
Fix/ci all checks #115
Conversation
- Actualizar tests de logging para nueva firma setup_logging() -> None - Corregir URL del endpoint invoice en test_operator.py (/api/invoice) - Corregir status code esperado 200 -> 201 para POST invoice - Mantener compatibilidad con CodeQL (zero-arg setup_logging) - 34/34 tests passing
- pytest 8.2.0 -> 8.4.2 - Reemplazar @app.on_event deprecado con app.router.on_startup/on_shutdown - 34/34 tests passing sin warnings
There was a problem hiding this comment.
Pull request overview
This PR focuses on addressing Railway deployment crashes and configuration updates, including dependency updates, code quality tooling configuration, and deprecation fixes. The changes primarily update testing dependencies, add Black formatter configuration, and migrate away from deprecated FastAPI event decorators.
Key changes include:
- Upgrading pytest from 8.2.0 to 8.4.2 for improved testing capabilities
- Adding Black code formatter configuration targeting Python 3.12
- Migrating from deprecated
@app.on_eventdecorators to router-based event handlers
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements.txt | Updates pytest to version 8.4.2 for improved testing support |
| pyproject.toml | Adds Black formatter configuration with line length 88 and Python 3.12 target |
| app/telemetry.py | Migrates from deprecated @app.on_event decorators to app.router.on_startup/on_shutdown |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| app.router.on_startup.append(startup_telemetry) | ||
| app.router.on_shutdown.append(shutdown_telemetry) |
There was a problem hiding this comment.
The use of app.router.on_startup and app.router.on_shutdown is deprecated in modern FastAPI versions and conflicts with the lifespan pattern already used in main.py. Since main.py already uses a lifespan context manager (lines 28-47), the recommended approach is to either:
- Move this telemetry initialization into the existing lifespan context manager in main.py, OR
- Use the new lifespan parameter approach with dependency injection
The current implementation appending to router events is discouraged when a lifespan handler is already defined, as it can lead to unpredictable execution order and maintenance issues.
🚀 Pull Request: Complete Railway Deployment Optimization
📋 Descripción del Cambio
Este PR implementa la solución completa para el problema de crashes de Railway después de 2 minutos, junto con la funcionalidad completa del dashboard administrativo para el sistema bancario NeuroBank FastAPI.
🎯 Problema Solucionado
✅ Solución Implementada
🔧 Cambios Técnicos Implementados
🚂 Railway Deployment
railway.json] Configuración con health checks y restart policiesstart.sh] Script de inicio inteligente con validacionesDockerfile] Optimización single worker + uvloop📊 Admin Dashboard
admin_transactions.html] Panel transacciones completo con Chart.jsadmin_users.html] Gestión usuarios con búsqueda en tiempo realadmin_reports.html] Reportes avanzados con exportación CSV/Excelrouter.py] Conexiones específicas (no más templates genéricos)🔄 CI/CD Pipeline
.github/workflows/production-pipeline.yml] Pipeline de 8 etapas📚 Documentation Suite
HOTFIX_RAILWAY_CRASH.md] Análisis técnico del problema RailwayWORKFLOW.md] Procedimientos de desarrolloGIT_COMMANDS_HOTFIX.md] Comandos de despliegue🧪 Testing & Validation
✅ Funcionalidad Validada
/healthoperativo🔒 Security Checks
⚡ Performance Tests
🎯 Business Impact
🚀 Deployment Instructions
Pre-merge Checklist
RAILWAY_TOKENconfigurado en GitHub SecretsPost-merge Actions
main👥 Review Requirements
🔍 Areas de Focus para Review
railway.jsonystart.sh🎯 Expected Reviewers
📝 Additional Notes
🔄 Future Improvements
📚 Related Documentation
✅ Ready to Merge Criteria
🎉 Este PR convierte NeuroBank FastAPI en una aplicación bancaria de nivel empresarial con despliegue automático y funcionalidad completa!